Add SiegeCamp object, created when a Siege is about to start. #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Object collects all the information required for the PreSiegeWarStartEvent and starting the actual Siege. Upon creation, a SiegeCamp begins a 10 minute period where on each minute if the attackers are present within the TimedPointZone, the attackers gain 7 points. After the 10 minute period, if the Attackers have 50 points the Siege will begin. Closes #402. TODO: - [ ] Language strings. - [ ] Configuration section for points, times. - [ ] Basic testing.
broadcasts informing server of SiegeCamp session.
Haxx0r-4559
approved these changes
Nov 18, 2021
Warriorrrr
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Object collects all the information required for the
PreSiegeWarStartEvent and starting the actual Siege.
Upon creation, a SiegeCamp begins a 10 minute period where on each
minute if the attackers are present within the TimedPointZone, the
attackers gain 7 points. After the 10 minute period, if the Attackers
have 50 points the Siege will begin.
TODO:
Language strings.
Configuration section for points, times.
Make SiegeCamps optional, falling back to old system when disabled.
Comments.
Basic testing.
Protect the banner for the duration of the SiegeCamp session.
Check that the war chest can still be paid.
New Nodes/Commands/ConfigOptions:
Relevant Issue ticket:
Closes #402.
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.