Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split vertical distance requirements surrounding capping into separate up and down values. #411

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

LlmDl
Copy link
Member

@LlmDl LlmDl commented Nov 23, 2021

Description:

Good for keeping players from being underneath the banner in pre-dug-out caves.


New Nodes/Commands/ConfigOptions:

New Config Options:

  • war.siege.distances.banner_control_vertical_distance_blocks_up",
    • 16
    • This is the vertical distance a soldier must be within above the
      Banner.
    • Note that the horizontal distance is always the same as the Towny
      townblock size.
  • war.siege.distances.banner_control_vertical_distance_blocks_down",
    • 4
    • This is the vertical distance a soldier must be within below the
      Banner.
    • Note that the horizontal distance is always the same as the Towny
      townblock size.

Removed Config Option:
war.siege.distances.banner_control_vertical_distance_blocks


Relevant Issue ticket:

Closes #405.


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.

up and down values.

New Config Options:
- war.siege.distances.banner_control_vertical_distance_blocks_up",
  - 16
  - This is the vertical distance a soldier must be within above the
Banner.
  - Note that the horizontal distance is always the same as the Towny
townblock size.
- war.siege.distances.banner_control_vertical_distance_blocks_down",
  - 4
  - This is the vertical distance a soldier must be within below the
Banner.
  - Note that the horizontal distance is always the same as the Towny
townblock size.

Removed Config Option:
war.siege.distances.banner_control_vertical_distance_blocks

Closes #405.
@LlmDl LlmDl added this to the 0.6.6 milestone Nov 23, 2021
@LlmDl LlmDl self-assigned this Nov 23, 2021
@LlmDl LlmDl added the enhancement New feature or request label Nov 23, 2021
@LlmDl LlmDl merged commit 59dccdc into master Nov 24, 2021
@LlmDl LlmDl deleted the feature/split_vertical_requirements branch November 24, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: change banner_control_vertical_distance_blocks setting to vertical up and vertical down.
1 participant