Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: change banner_control_vertical_distance_blocks setting to vertical up and vertical down. #405

Closed
ghost opened this issue Nov 20, 2021 · 0 comments · Fixed by #411
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ghost
Copy link

ghost commented Nov 20, 2021

Is your feature request related to a problem? Please describe.
There exist a setting banner_control_vertical_distance_blocks that sets the vertical distance a banner can be capped. But this setting is setting the distance on the vertical axis down and up. This makes it impossible to control below the banner without affecting above the banner. With the setting to disallow digging under the siege zone, it is still possible for players to dig out before a siege happens.

Describe the solution you'd like
Split the setting banner_control_vertical_distance_blocks into banner_control_vertical_distance_blocks_up and banner_control_vertical_distance_blocks_down and allow them to be set separately.

@ghost ghost added the enhancement New feature or request label Nov 20, 2021
@LlmDl LlmDl added this to the 0.6.6 milestone Nov 20, 2021
LlmDl added a commit that referenced this issue Nov 23, 2021
up and down values.

New Config Options:
- war.siege.distances.banner_control_vertical_distance_blocks_up",
  - 16
  - This is the vertical distance a soldier must be within above the
Banner.
  - Note that the horizontal distance is always the same as the Towny
townblock size.
- war.siege.distances.banner_control_vertical_distance_blocks_down",
  - 4
  - This is the vertical distance a soldier must be within below the
Banner.
  - Note that the horizontal distance is always the same as the Towny
townblock size.

Removed Config Option:
war.siege.distances.banner_control_vertical_distance_blocks

Closes #405.
@LlmDl LlmDl self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant