SiegeRemoveEvent and punctuation fixes

[ewof]

Description:

• add a siege remove event so plugins can handle when sieges are remove by immunity running out or via admin command
• fixes some weird !. punctuation's in en-US

---

New Nodes/Commands/ConfigOptions:

---

• I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.

[Goosius1]

🚧
Hi,
As clarified on Discord yesterday:

• For the siege removal event, that's no problem. I presume that event would also be fired when the Siege is naturally removed after SiegeImmunity runs out.

• For the config option on moving the flag, no unfortunately we can't add that yet. I don't want to provide such a config in the plugin unless/until a robust and well-tested overall town-invasion system is ready to roll out. The reason is that if that was provided, some server's would use it, many could end up in mess, which would negatively effect the reputation of the team and system. Thus please remove that config from this PR, then I will resume the review.

[LlmDl]

I think it makes more sense to throw the remove event from within the SiegeController.removeSiege() method, as there's still 3 places that call removeSiege(siege) which are not going to throw the event.

[LlmDl]

Found one last typo in a lang file.

[LlmDl]

Looks good to me, I'll leave this in Goosius' hands to merge.

[Goosius1]

Thanks so much Llama!. I'll do a quick pass secondary review on this now.