Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOL interface changes/redundancy removal #3677

Merged
merged 11 commits into from Feb 11, 2020
Merged

QOL interface changes/redundancy removal #3677

merged 11 commits into from Feb 11, 2020

Conversation

@suneettipirneni
Copy link
Contributor

suneettipirneni commented Jan 30, 2020

Description:

  • Removed TownyAllySender, and ResidentModes because they were only being used in singular classes defeating the purpose of the interface, so they were combined into their respective classes.
  • Made PlotGroup conform to TownBlockOwner to further standardize implementation.
  • New interface Nameable introduced in order for objects that don't extend TownyObject to have the ability to get their names extracted, ie PlotGroup.
  • New interface Bank, an extension of EconomyHandler for objects that have a bank.
  • Various areas of code have been simplified slash deleted for trivial reasons.

As a result, we've been able to trim the code count slight in this PR


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

- Removed TownyAllySender, and ResidentModes.java because they were only being used in singular classes defeating the purpose of the interface, so they were combined into their respective classes.
- Made PlotGroup conform to TownBlockOwner to introduce more standard implementation.
- New interface Nameable introduced in order for objects that don't extend `TownyObject` to be operated on i.e PlotGroups.
@suneettipirneni suneettipirneni changed the title QOL changes/redundancy removal QOL interface changes/redundancy removal Jan 30, 2020
- Added Bank interface to generify objects that contain banks.
- Simplified a lot of Town/Nation code and removed some that didn't do anything.
@suneettipirneni suneettipirneni self-assigned this Feb 1, 2020
… refactor/interface-redux

# Conflicts:
#	.github/workflows/compile-on-push.yml
@suneettipirneni suneettipirneni requested a review from LlmDl Feb 8, 2020
Copy link
Member

LlmDl left a comment

It looks good I guess it just needs to have some bits explained and a few things tested,

…hub.com/TownyAdvanced/Towny into refactor/interface-redux

� Conflicts:
�	src/com/palmergames/bukkit/towny/object/Town.java
@suneettipirneni suneettipirneni requested a review from LlmDl Feb 11, 2020
@LlmDl
LlmDl approved these changes Feb 11, 2020
@LlmDl LlmDl merged commit 7bbb11d into master Feb 11, 2020
2 checks passed
2 checks passed
build
Details
build
Details
@LlmDl LlmDl deleted the refactor/interface-redux branch Feb 11, 2020
LlmDl added a commit that referenced this pull request Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.