Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese(hant) language pack support 0.71 #3689

Merged
merged 2 commits into from Feb 14, 2020
Merged

Conversation

@shou692199
Copy link
Contributor

shou692199 commented Feb 8, 2020

Description:


New Nodes/Commands/ConfigOptions:


Relevant Towny Issue ticket:


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

@LlmDl

This comment has been minimized.

Copy link
Member

LlmDl commented Feb 8, 2020

So this is zh-TW or something else?

@shou692199

This comment has been minimized.

Copy link
Contributor Author

shou692199 commented Feb 9, 2020

It' zh-TW version

@LlmDl

This comment has been minimized.

Copy link
Member

LlmDl commented Feb 9, 2020

Great, would it make more sense to be Taiwanese.yml or zh-TW.yml?

@TheFlagCourier

This comment has been minimized.

Copy link
Contributor

TheFlagCourier commented Feb 12, 2020

I'm for zh-TW, since language codes are pretty universal. We're already following that standard with the Spanish translations.

@shou692199

This comment has been minimized.

Copy link
Contributor Author

shou692199 commented Feb 14, 2020

Sure that's fine.You can rename it to zh-TW.

@LlmDl LlmDl merged commit e44ecb0 into TownyAdvanced:master Feb 14, 2020
1 check passed
1 check passed
build
Details
LlmDl added a commit that referenced this pull request Feb 14, 2020
    - set language: zh-TW.yml in config to use.
@shou692199 shou692199 deleted the shou692199:patch-1 branch Feb 15, 2020
@shou692199 shou692199 restored the shou692199:patch-1 branch Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.