Hotfix: Fix version strings pickup up unneeded input.

[ghost]

Description:

Fixes issue where players using the version: "x.x.x.x-for-x.x.x" would receive errors because the version string was not sanitized.

---

• I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

[ghost]

This has been mergable for a bit now

[LlmDl]

Yeah we were looking at it and it seems a bit overkill. Changing things to versions just to get a string from it in the end. The original problem really only needs to have the non-number bits stripped off it like you did with the pattern matcher.

[ghost]

Yeah we were looking at it and it seems a bit overkill. Changing things to versions just to get a string from it in the end. The original problem really only needs to have the non-number bits stripped off it like you did with the pattern matcher.

It is getting stripped, the reason I'm using Version instead of String in many areas is because the version class allows us to do comparisons between versions you can't compare versions if they're just in a string format. For example if you're given two version strings you can't easily compute which one is less than/greater than.

[silverwolfg11]

Is there a way to abstract a lot of the visible string parsing out. I don't mind using the Version class to better check version comparison if that's more effective. It just seems like all the string parsing like .split to get the the proper format to plug into the version can be done a bit more clean.

Maybe instead of having the pattern in string mgmt you move it to the version class and then you have a static like Version.parse() method?

Furthermore I'm noticing that TownySettings.getRunLastVersion() also needs a lot of string manipulation. Is there a way to create a method in TownySettings that contains the major use-case and forwards onto the actual getRunLastVersion like maybe a method by the same name that has no parameters but forwards to TownySettings.getRunLastVersion("0.0.0.0").

Just stuff to make it more clean in general.

[LlmDl]

I'll do some further testing on this later, thanks.