Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for compressed blob uploads #260

Open
chrisstaite-menlo opened this issue Sep 9, 2023 · 5 comments
Open

Add support for compressed blob uploads #260

chrisstaite-menlo opened this issue Sep 9, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@chrisstaite-menlo
Copy link
Collaborator

Currently we only support compression on the transport, add support for compressed uploads:

main/uploads/94448848-5c26-4e27-9448-50f9fea1947e/compressed-blobs/zstd/33cc97ba1cbeb6c3c542d594f3d96cf0a80f562a287c50f61783763be42586bd/79
@chrisstaite-menlo
Copy link
Collaborator Author

First update remote_execution.proto to v2.3 in #268
Then we can add support for the different compression types

@chrisstaite-menlo
Copy link
Collaborator Author

#281 adds support for reading the compressed blob resource names. Now we just need to handle the compressed blob.

@chrisstaite-menlo
Copy link
Collaborator Author

Might be nice if these were passed through GrpcStore and then if the CompressionStore were in use it could simply used the pre-compressed content?

@allada
Copy link
Member

allada commented Sep 16, 2023

Might be nice if these were passed through GrpcStore and then if the CompressionStore were in use it could simply used the pre-compressed content?

We can read the capabilities API in the GrpcStore, and if it supports compressed uploads/downloads use it?

@blizzardc0der
Copy link
Contributor

I'd like to work on this issue. cc: @allada

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants