-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry GrpcStore write #326
Retry GrpcStore write #326
Conversation
3961bf3
to
6924755
Compare
This still doesn't resolve the issue:
The remote logs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@aaronmondal , do you want to take this one?
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @aaronmondal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisstaite-menlo LGTM, just needs rebase onto your other PR ❤️
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @chrisstaite-menlo)
d837348
to
ad20db9
Compare
ad20db9
to
7eee0cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
Description
When writing to the GrpcStore retry was not implemented as there was no easy way to rewind the stream. However, most errors due to high concurrency occur before any data has been written. Therefore, refactor the GrpcStore::write such that it can retry if the stream has not yet been used.
Fixes #325
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
High concurrency use of the GrpcStore, no longer producing errors from the ByteStreamServer.
Checklist
bazel test //...
passes locallygit amend
see some docsThis change is