Avoid writer EOF until fast store complete #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisstaite-menlo
force-pushed
the
fast_store_dropped
branch
2 times, most recently
from
89fd0da
to
63eadf5
Compare
Currently we send the EOF to the fast store and the requester at the same time. The bytestream_server drops the get_part future as soon as it receives the EOF which means that the fast store doesn't get time to sync and populate. This is resolved by only sending the EOF to the requestor in the fast_slow_store once all of the futures have completed. The alternative is to spawn for the fast store or to complete the get_part future in bytestream_server, but this seems like the least heavy weight solution which doesn't require thought by the user.
chrisstaite-menlo
force-pushed
the
fast_store_dropped
branch
from
63eadf5
to
a88491e
Compare
adam-singer
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @allada)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we send the EOF to the fast store and the requester at the same time. The bytestream_server drops the get_part future as soon as it receives the EOF which means that the fast store doesn't get time to sync and populate.
This is resolved by only sending the EOF to the requestor in the fast_slow_store once all of the futures have completed. The alternative is to spawn for the fast store or to complete the get_part future in bytestream_server, but this seems like the least heavy weight solution which doesn't require thought by the user.
Fixes #478
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Testing with long latency link between two instances.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is