Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves custom crates to nativelink dirs for disambiguation #483

Merged

Conversation

MarcusSorealheis
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis commented Dec 14, 2023

Description

Two crates, error and proto needed to be moved into nativelink specific dirs.

Type of change

Rename

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist

  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this, occurrences of proto:: and error:: need to be changed to nativelink_proto:: and nativelink_error::.

Reviewable status: 0 of 31 files reviewed, all discussions resolved

Copy link
Collaborator Author

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed this

Reviewable status: 0 of 110 files reviewed, all discussions resolved

Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but I thinkg you need to run

  bazel run \
    --@rules_rust//:rustfmt.toml=//:.rustfmt.toml \
    @rules_rust//:rustfmt

To reorder the imports.

Reviewed 30 of 31 files at r1, 80 of 80 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarcusSorealheis)


-- commits line 2 at r2:
nit: Try to remember to capitalize the initial letter and remove the trailing period on merge.

Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 79 of 79 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MarcusSorealheis)

@MarcusSorealheis MarcusSorealheis force-pushed the rename-custom-crates branch 6 times, most recently from 769127a to fabc2b3 Compare December 15, 2023 03:21
Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to merge this. Ignore the failing proto test. I can send a fix for that immediately after this PR is merged.

Reviewed 6 of 14 files at r4, 1 of 8 files at r5, 1 of 1 files at r6, 4 of 4 files at r7, all commit messages.
Reviewable status: 126 of 132 files reviewed, all discussions resolved (waiting on @allada)

@MarcusSorealheis MarcusSorealheis merged commit 1aadd42 into TraceMachina:main Dec 15, 2023
11 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants