Don't remove Error context. #199
Conversation
Unexplicably, the Error context was removed when getting the upstream data from a GrpcStore. This means that the Code::NotFound is removed and copious error messages are spewed for missing action cache entries. Resolves TraceMachina#197
|
I'd like to write a test for this, but there are no tests for GrpcStore currently and my previous attempt at writing a test for a Grpc upstream ended up pulling in a lot of dependencies to get it to connect and it was requested to be removed, so I'm leaving this without a regression test unless advised otherwise. |
There was a problem hiding this comment.
Uuug, writing a test for this is going to suck. Can we make a ticket for this to write a regression test for this? This probably needs to be figured out for grpc_scheduler too.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @chrisstaite-menlo)
|
Have raised #200 |
Unexplicably, the Error context was removed when getting the upstream data from a GrpcStore. This means that the Code::NotFound is removed and copious error messages are spewed for missing action cache entries.
Resolves #197
This change is