-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrapping GrpcStore with FastSlowStore failure for AC #197
Comments
Digging into this a little, I think it's dumping a horrible error just because the ActionResult wasn't found in the ActionCache. So we just need to catch the error rather than print it I think... |
Furthermore, I think this is simply caused by the removal of the |
chrisstaite-menlo
added a commit
to chrisstaite-menlo/turbo-cache
that referenced
this issue
Jul 17, 2023
Unexplicably, the Error context was removed when getting the upstream data from a GrpcStore. This means that the Code::NotFound is removed and copious error messages are spewed for missing action cache entries. Resolves TraceMachina#197
chrisstaite-menlo
added a commit
that referenced
this issue
Jul 17, 2023
Unexplicably, the Error context was removed when getting the upstream data from a GrpcStore. This means that the Code::NotFound is removed and copious error messages are spewed for missing action cache entries. Resolves #197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now that GrpcStore supports forwarding to an upstream AcServer, I attempted wrapping it in a FastSlowStore to make a local cache and am getting the following error:
This is obviously not as expected, so something is wrong with the implementation. I haven't dug into what's causing it yet.
The text was updated successfully, but these errors were encountered: