Generalize k8s workers #812
Conversation
There was a problem hiding this comment.
+@adam-singer +@allada +@blakehatch
cc @thelabdude
FYI the first commit here is from #809
Reviewable status: 0 of 3 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04 (waiting on @adam-singer, @allada, and @blakehatch)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: 1 of 3 LGTMs obtained (waiting on @adam-singer and @blakehatch)
There was a problem hiding this comment.
@aaronmondal lets sync to update #786 when this lands
Reviewable status: 2 of 3 LGTMs obtained (waiting on @blakehatch)
Different worker images may now reuse the same `worker.json` config file. This significantly simplifies the Kubernetes setup and provides a clear path towards using custom worker images. The Kubernetes example is now a fairly standard kustomize application and should be straightforward to port to Helm charts that support remote execution.
aaronmondal
force-pushed
the
generalize-k8s-workers
branch
from
5101508
to
7732ba3
Compare
There was a problem hiding this comment.
Reviewable status: 2 of 2 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04
Different worker images may now reuse the same
worker.jsonconfigfile. This significantly simplifies the Kubernetes setup and provides a
clear path towards using custom worker images.
The Kubernetes example is now a fairly standard kustomize application
and should be straightforward to port to Helm charts that support remote
execution.
This change is