Allow variables in platform property values #809
Conversation
This lets us use a combination of init-containers and entrypoint scripts to pass dynamic container image tags and other values into workers.
aaronmondal
force-pushed
the
dynamic-platform-properties
branch
from
bc57a90
to
1e96b10
Compare
There was a problem hiding this comment.
cc @chrisstaite-menlo @kubevalet
Reviewable status: 0 of 2 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, Vercel, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04 (waiting on @adam-singer and @allada)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @adam-singer)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained
This lets us use a combination of init-contaiers and entrypoint scripts to pass dynamic container image tags and other values into workers.
This change is