Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide example does not compile due to cubecl update #2082

Closed
shinglyu opened this issue Jul 30, 2024 · 2 comments
Closed

Guide example does not compile due to cubecl update #2082

shinglyu opened this issue Jul 30, 2024 · 2 comments

Comments

@shinglyu
Copy link

Describe the bug

The examples/guide does not compile because of an updated parameter type in the cubecl dependency.

To Reproduce

  1. cd examples/guide
  2. cargo run --bin train --release

Expected behavior
The example compiles and runs.

Screenshots
Got multiple compile errors like this:
error[E0308]: mismatched types
--> crates/burn-jit/src/fusion/elemwise/kernel.rs:98:84
|
98 | let cube_count = calculate_cube_count_elemwise(num_elems / factor, self.cube_dim);
| ----------------------------- ^^^^^^^^^^^^^ expected usize, found CubeDim
| |
| arguments to this function are incorrect
|
note: function defined here
--> /home/sagemaker-user/.cargo/git/checkouts/cubecl-aa41a28b39b598f9/2b95a9e/crates/cubecl-core/src/lib.rs:55:8
|
55 | pub fn calculate_cube_count_elemwise<S: ComputeServer>(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^


**Desktop (please complete the following information):**
 - OS: Ubuntu 22.04.4 LTS (in SageMaker Studio CodeEditor)
 - Browser: N/A
 - Version: N/A

**Additional context**
cubecl was updated 5 days ago: https://github.com/tracel-ai/cubecl/commit/367bd4c38ae16bb4660a60399bbb4a4c95e02755 with this breaking change. But a `cargo update cubecl` does not seem to fix it.
@shinglyu
Copy link
Author

Root cause: tracel-ai/cubecl#44

@nathanielsimard
Copy link
Member

We fixed the problem by setting the correct version of burn: eb9e822

Since CubeCL is early we won't create a release for every breaking changes, only when publishing Burn, so that both project can evolve together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants