Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable burn fusion by default #1223

Merged
merged 11 commits into from
Feb 8, 2024
Merged

Conversation

nathanielsimard
Copy link
Member

@nathanielsimard nathanielsimard commented Feb 1, 2024

To simplify the utilization of the new fusion backend and enhance performance by default, we will enable the fusion backend decorator using a feature flag instead of requiring users to add it, which may be forgotten.

type MyBackend = Fusion<Wgpu>; // Old
type MyBackend = Wgpu; // New

To achieve this, we will rename the current backend to WgpuBackend and export the type alias Wgpu, pointing to the correct backend type. We will also update the documentation for each with the appropriate modifications.

@nathanielsimard nathanielsimard marked this pull request as draft February 1, 2024 15:01
@nathanielsimard nathanielsimard marked this pull request as ready for review February 7, 2024 23:51
@nathanielsimard nathanielsimard changed the title [WIP] Enable burn fusion by default Enable burn fusion by default Feb 7, 2024
Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

///
/// # Notes
///
/// This version of the [wgpu] backend doesn't uses [burn_fusion] to compile and optimize streams of tensor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use

@nathanielsimard nathanielsimard merged commit a9b6dbc into main Feb 8, 2024
12 checks passed
@nathanielsimard nathanielsimard deleted the feat/fusion/enable-default branch February 8, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants