Couple of changes in WGSL layer #1231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. ONNX IR fix ReduceL* 3. ignoring ipynb checkpoints
# Conflicts: # burn-book/src/building-blocks/tensor.md
# Conflicts: # burn-autodiff/src/ops/tensor.rs # burn-candle/src/lib.rs # burn-candle/src/ops/tensor.rs # burn-fusion/src/ops/float.rs # burn-fusion/src/stream/operation.rs # burn-ndarray/src/ops/tensor.rs # burn-tch/src/ops/tensor.rs # burn-wgpu/src/ops/float_ops.rs
louisfd
requested changes
Feb 7, 2024
| @@ -28,7 +28,11 @@ fn main( | |||
|
|
|||
| if id_local == 0u { | |||
| var sum = {{ elem }}(0); | |||
| for (var i: u32 = 0u; i < WORKGROUP_SIZE; i++) { | |||
| var num_data = min(WORKGROUP_SIZE, arrayLength(&input) % WORKGROUP_SIZE); | |||
There was a problem hiding this comment.
From myself on discord: "it has to depend on the invocation id, because now imagine you have workgroup_size=1000 ans input length is 2500. You will want 1000, 1000, 500 but the formula with min and modulo will give 500, 500, 500"
There was a problem hiding this comment.
Error in CI is likely to be caused by that
|
I assume this PR is blocked? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
The changes are issues identified during #1173
Changes
Fixes a couple of edge cases with sum/reduction WGSL layer.
Testing
"run-checks all"
TBD