Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bool() op for numerical tensor #1402

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Conversation

antimora
Copy link
Collaborator

@antimora antimora commented Mar 4, 2024

Fixes #1395

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Fixes #1395

Changes

  1. Add bool() op for numerical tensor
  2. Add new unit tests
  3. Update the book

Testing

Add new unit tests

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.73%. Comparing base (046d975) to head (696913a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1402   +/-   ##
=======================================
  Coverage   85.72%   85.73%           
=======================================
  Files         608      609    +1     
  Lines       69745    69761   +16     
=======================================
+ Hits        59792    59808   +16     
  Misses       9953     9953           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antimora antimora merged commit 4ed90a9 into tracel-ai:main Mar 4, 2024
14 checks passed
@antimora antimora deleted the tensor-bool branch March 5, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tensor .bool() operator
3 participants