Autodiff/training support for Nearest Interpolation #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: bilinear interpolation for tch, ndarray and wgpu backend fix: reduce test case size to avoid exceeding floating-point precision limits feat: support nearest-neighbor interpolation for ndarray backend feat: support nearest-neighbor interpolation for wgpu backend feat: support fusion backend fix: no-std support build: upgrade dependencies
…ku/burn into feat/interpolation merge upstream changes :wq!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1414 +/- ##
==========================================
- Coverage 85.81% 85.80% -0.02%
==========================================
Files 610 611 +1
Lines 70417 70715 +298
==========================================
+ Hits 60428 60674 +246
- Misses 9989 10041 +52 ☔ View full report in Codecov by Sentry. |
|
Some more context: For Tch-backend -> Backward passes for all interpolation types(nearest, bilinear, bicubic) are supported in this PR. Bilinear, Bicubic for the backends(ndarray, wsgl) are under progress in another branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
#1393
Changes
This PR implements the backward pass for nearest interpolation for all backends (Ndarray, Tch, WGPU) except Candle. This ensures that training can now be done with this operation. Nearest neighbour interpolation is generally a popular and default method for up/down sampling.
Testing