Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitted the JIT stuff from the Wgpu stuff #1417

Merged
merged 32 commits into from
Mar 6, 2024
Merged

Conversation

nathanielsimard
Copy link
Member

The JIT backend still have a dependency on wgsl, since some shaders are written in it and not yet ported to our new compiler, but this isn't a problem for now.

Deleted some matmul kernels that aren't used or not relevant anymore.
All tests in burn-jit now follow the same pattern as with burn-tensor and burn-autodiff; each tests in exported and run on the concrete implementation.

@nathanielsimard nathanielsimard marked this pull request as draft March 5, 2024 18:09
[package]
authors = ["nathanielsimard <nathaniel.simard.42@gmail.com>"]
categories = ["science"]
description = "WGPU backend for the Burn framework"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description is out of date

@nathanielsimard nathanielsimard marked this pull request as ready for review March 6, 2024 14:01
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 93.34812% with 150 lines in your changes are missing coverage. Please review.

Project coverage is 85.67%. Comparing base (0c92c8c) to head (48b0632).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/burn-wgpu/src/runtime.rs 57.64% 72 Missing ⚠️
crates/burn-jit/src/kernel/prng/uniform.rs 54.73% 43 Missing ⚠️
crates/burn-jit/src/tests/matmul.rs 96.89% 16 Missing ⚠️
crates/burn-jit/src/fusion/base.rs 0.00% 4 Missing ⚠️
crates/burn-wgpu/src/fusion.rs 50.00% 4 Missing ⚠️
crates/burn-jit/src/compute/kernel.rs 92.85% 3 Missing ⚠️
.../burn-jit/src/codegen/dialect/gpu/vectorization.rs 75.00% 2 Missing ⚠️
crates/burn-jit/src/kernel/interpolate.rs 0.00% 2 Missing ⚠️
crates/burn-jit/src/kernel/mask/mask_fill.rs 98.46% 1 Missing ⚠️
crates/burn-jit/src/kernel/mask/mask_where.rs 98.57% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1417      +/-   ##
==========================================
- Coverage   85.83%   85.67%   -0.16%     
==========================================
  Files         613      637      +24     
  Lines       71148    70286     -862     
==========================================
- Hits        61068    60219     -849     
+ Misses      10080    10067      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit b429cc3 into main Mar 6, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the refactor/jit/backend branch March 6, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants