Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enum module support in PyTorchFileRecorder #1436

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

antimora
Copy link
Collaborator

@antimora antimora commented Mar 8, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Fixes #1431

Changes

  1. Updated Deserializer logic for deserialize_enum
  2. Added tests
  3. Updated the book section

Testing

  1. New unit tests
  2. Rendered the book

@antimora antimora requested a review from laggui March 8, 2024 22:43
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 91.70306% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 85.83%. Comparing base (093cbd3) to head (6662ed9).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/burn-core/src/record/serde/de.rs 75.32% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1436      +/-   ##
==========================================
+ Coverage   85.79%   85.83%   +0.03%     
==========================================
  Files         642      643       +1     
  Lines       71271    71494     +223     
==========================================
+ Hits        61150    61365     +215     
- Misses      10121    10129       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just two minor typos/wording issue but approving in advance.

Thanks for working on this 🙂

burn-book/src/import/pytorch-model.md Outdated Show resolved Hide resolved
burn-book/src/import/pytorch-model.md Outdated Show resolved Hide resolved
@antimora antimora merged commit 0138e16 into tracel-ai:main Mar 11, 2024
14 checks passed
@antimora antimora deleted the enum-pytorch-1431 branch March 11, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record Deserializer not implemented for enum
2 participants