Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sign tensor operator #1446

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Add sign tensor operator #1446

merged 1 commit into from
Mar 11, 2024

Conversation

antimora
Copy link
Collaborator

@antimora antimora commented Mar 10, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Fixes #522

Changes

  1. Default sign OP in Numerical trait
  2. Backwards autodiff
  3. Ndarray and Tch backends
  4. Docs are updated

The Candle backend does not support currently (see huggingface/candle#1827 and #1447) and will use default implementation. WGPU uses default implementation as well (#1445 is filed to improve).

Testing

  1. New unit tests
  2. run-checks succeeded.

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 87.30159% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 85.76%. Comparing base (56f4602) to head (441e7a3).

Files Patch % Lines
crates/burn-tch/src/ops/int_tensor.rs 0.00% 5 Missing ⚠️
crates/burn-tch/src/ops/tensor.rs 0.00% 5 Missing ⚠️
crates/burn-autodiff/src/ops/int_tensor.rs 0.00% 3 Missing ⚠️
crates/burn-tch/src/ops/base.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1446    +/-   ##
========================================
  Coverage   85.76%   85.76%            
========================================
  Files         640      642     +2     
  Lines       70632    70758   +126     
========================================
+ Hits        60577    60687   +110     
- Misses      10055    10071    +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antimora antimora merged commit 3f7e6bd into tracel-ai:main Mar 11, 2024
14 checks passed
@antimora antimora deleted the sign-tensor-op branch March 11, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sign tensor operator for copying sign of one tensor onto another
3 participants