-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate/jit/matmul tiling 2d #1472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comment, otherwise looks good
let tmp = scope.create_local(Elem::UInt); | ||
let position_0 = scope.create_local(Elem::UInt); | ||
let position_1 = scope.create_local(Elem::UInt); | ||
let position_2 = scope.create_local(Elem::UInt); | ||
let position_3 = scope.create_local(Elem::UInt); | ||
let remain_n = scope.create_local(Elem::Bool); | ||
|
||
let val_0 = scope.zero(elem); | ||
let val_1 = scope.zero(elem); | ||
let val_2 = scope.zero(elem); | ||
let val_3 = scope.zero(elem); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extract those else where, the declaration is probably done in a for loop. Also, not sure we need to initialize val_0, val_1, val_2 and val_3 to zero.
…urn into migrate/jit/matmul_tiling_2d
Matmul tiling 2d kernels for #1422
Bonus stuff: