Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sort descending for 1d case #1494

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fix sort descending for 1d case #1494

merged 1 commit into from
Mar 21, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Mar 20, 2024

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

Fix from previous PR #1488

Changes

Forgot to validate one edge case 🤦slight oversight on my end.

Was working on a quick implementation for topk now that sorting operations were merged and I stumbled upon this issue.

Testing

Added a unit test for sort_descending with a 1D tensor.

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho well, didn't see that one either 🤦

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.79%. Comparing base (47a84cc) to head (12f5ed3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1494      +/-   ##
==========================================
- Coverage   85.86%   85.79%   -0.08%     
==========================================
  Files         659      659              
  Lines       74082    74122      +40     
==========================================
- Hits        63612    63590      -22     
- Misses      10470    10532      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laggui laggui merged commit 3e4af41 into main Mar 21, 2024
15 checks passed
@laggui laggui deleted the fix/sort-descending-1d branch March 21, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants