Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/swiglu #1507

Merged
merged 9 commits into from
Mar 25, 2024
Merged

Feat/swiglu #1507

merged 9 commits into from
Mar 25, 2024

Conversation

ashdtu
Copy link
Contributor

@ashdtu ashdtu commented Mar 22, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#1504

Changes

Implement SwiGLU activation module to be used in LLM models

@ashdtu ashdtu requested review from antimora and louisfd March 22, 2024 15:03
@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.95238% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 85.90%. Comparing base (8911093) to head (b5816bd).
Report is 12 commits behind head on main.

Files Patch % Lines
crates/burn-core/src/nn/swiglu.rs 80.95% 12 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1507      +/-   ##
==========================================
+ Coverage   85.86%   85.90%   +0.04%     
==========================================
  Files         653      665      +12     
  Lines       73068    75799    +2731     
==========================================
+ Hits        62738    65118    +2380     
- Misses      10330    10681     +351

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

antimora
antimora requested changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks but tests are missing for some reason.

louisfd
louisfd approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small comment but approved in advance

crates/burn-core/src/nn/swiglu.rs Outdated Show resolved Hide resolved
@ashdtu ashdtu requested a review from antimora March 25, 2024 17:02
@ashdtu
Copy link
Contributor Author

ashdtu commented Mar 25, 2024

@antimora Added tests. Let me know if it looks good to merge.

antimora
antimora approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielsimard nathanielsimard merged commit 613e698 into main Mar 25, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the feat/swiglu branch March 25, 2024 19:55
@ashdtu ashdtu mentioned this pull request Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisfd louisfd louisfd approved these changes

@antimora antimora antimora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashdtu @antimora @louisfd @nathanielsimard