Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: Filling tensor containing f32::NEG_INFINITY will result in NaN for burn-ndarray #2095

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

antimora
Copy link
Collaborator

@antimora antimora commented Aug 3, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Fixes #2094

Changes

  1. Fixed mask_fill burn-ndarray method
  2. Added regression test

Testing

New regression test

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.23%. Comparing base (f7639bd) to head (cba386a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2095   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files         688      688           
  Lines       88465    88483   +18     
=======================================
+ Hits        76285    76303   +18     
  Misses      12180    12180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix 🙂

@laggui laggui merged commit 80cc6d4 into tracel-ai:main Aug 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filling tensor containing f32::NEG_INFINITY will result in NaN
2 participants