Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cumsum #2099

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

cBournhonesque
Copy link
Contributor

@cBournhonesque cBournhonesque commented Aug 4, 2024

Pull Request Template

I'm opening the PR draft early just to see if i'm on the right track!

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.
  • ndarray
  • candle
  • tch
  • autodiff
  • jit
  • fusion
  • import

Related Issues/PRs

Issue: #1720

Changes

Add cumsum for ndarray

Testing

Added unit test

@antimora
Copy link
Collaborator

antimora commented Aug 5, 2024

Just be aware there is an open PR related #1722

Maybe we could combine the efforts? Although the author just came back with a response.

@antimora
Copy link
Collaborator

antimora commented Aug 5, 2024

I would recommend taking on import change in a separate PR.

@cBournhonesque
Copy link
Contributor Author

Just be aware there is an open PR related #1722

Maybe we could combine the efforts? Although the author just came back with a response.

Oh i didn't see there was an existing one already!
Would it be worth merging a version without the burn-jit backend first?
And then add the burn-jit and burn-import separately?

@laggui
Copy link
Member

laggui commented Aug 23, 2024

Just be aware there is an open PR related #1722
Maybe we could combine the efforts? Although the author just came back with a response.

Oh i didn't see there was an existing one already! Would it be worth merging a version without the burn-jit backend first? And then add the burn-jit and burn-import separately?

Sorry for the delayed response here, didn't notice this draft 🫣

I think we can definitely start without the burn-jit and burn-import implementation, we can isolate that in another PR if it's currently blocking.

The ONNX import has been partially completed in the linked PR, so it could be completed from there.

Copy link
Contributor

This PR has been marked as stale because it has not been updated for over a month

@github-actions github-actions bot added the stale The issue or pr has been open for too long label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The issue or pr has been open for too long
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants