Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision option for tensor display #2139

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

antimora
Copy link
Collaborator

@antimora antimora commented Aug 8, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

  1. Add global precision option
  2. Add formatter precision option
  3. Add unit tests
  4. Improve locking of the global option

Testing

New unit test for formatter precision option. The global precision settings were tested manually because the change affects other test threads.

Copy link
Contributor

@mepatrick73 mepatrick73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few left out comments to be removed. I'll approve in advance 👍

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.29%. Comparing base (d770b1f) to head (7dba380).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/burn-tensor/src/tensor/api/base.rs 76.66% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2139   +/-   ##
=======================================
  Coverage   86.29%   86.29%           
=======================================
  Files         694      694           
  Lines       89005    89070   +65     
=======================================
+ Hits        76806    76865   +59     
- Misses      12199    12205    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh that's pretty useful! Thanks for adding this 😄

@antimora
Copy link
Collaborator Author

antimora commented Aug 8, 2024

Thanks for reviewing my precision PR.

The left comments were intentional. Do you think I should still remove them?

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only comment left to document restrictions seems fine to me :) thanks for the changes

@antimora antimora merged commit 1c681f4 into tracel-ai:main Aug 8, 2024
12 checks passed
@antimora antimora deleted the print-precision branch August 8, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants