-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deform_conv2d as implemented in torchvision #2147
Conversation
Currently blocked on atomics being added to |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2147 +/- ##
==========================================
- Coverage 85.79% 85.67% -0.13%
==========================================
Files 754 760 +6
Lines 95189 99082 +3893
==========================================
+ Hits 81671 84888 +3217
- Misses 13518 14194 +676 ☔ View full report in Codecov by Sentry. |
Finally done and ready to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions, otherwise very nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add Deformable Convolution Layers v1/v2
Help would be welcome, I've been looking at the kernel so long I can no longer see my mistakes. Getting a few more pairs of eyes on it would be helpful.
Checklist
run-checks all
script has been executed.Related Issues/PRs
A lot of resnet variants currently replace most conv2d layers with deform_conv2d. See torchvision docs
Changes
Adds the relatively popular deform_conv2d layer initially implemented in torchvision in 2021.
Testing