Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: point to new schemata #12

Merged
merged 3 commits into from
Nov 23, 2023
Merged

feat: point to new schemata #12

merged 3 commits into from
Nov 23, 2023

Conversation

cavacado
Copy link

@cavacado cavacado commented Nov 23, 2023

due to the updating of new schemata, test documents need to be regenerated, thus this pr addresses that issue.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

test/fixtures/v4/tt/did-idvc-wrapped-signed.json|35 col 22| Replace ⏎··············"CorporateBasicDetails"⏎············ with "CorporateBasicDetails"
test/fixtures/v4/tt/did-idvc-wrapped-signed.json|131 col 2| Insert
test/fixtures/v4/tt/did-idvc-wrapped-tampered-signature.json|6 col 12| Replace ⏎····"VerifiableCredential",⏎····"TradeTrustCredential"⏎·· with "VerifiableCredential",·"TradeTrustCredential"
test/fixtures/v4/tt/did-idvc-wrapped-tampered-signature.json|28 col 20| Replace ⏎············"VerifiableCredential"⏎·········· with "VerifiableCredential"
test/fixtures/v4/tt/did-idvc-wrapped-tampered-signature.json|35 col 22| Replace ⏎··············"CorporateBasicDetails"⏎············ with "CorporateBasicDetails"
test/fixtures/v4/tt/did-idvc-wrapped-tampered-signature.json|129 col 2| Insert
test/fixtures/v4/tt/did-idvc-wrapped-wrong-binding.json|6 col 12| Replace ⏎····"VerifiableCredential",⏎····"TradeTrustCredential"⏎·· with "VerifiableCredential",·"TradeTrustCredential"
test/fixtures/v4/tt/did-idvc-wrapped-wrong-binding.json|28 col 20| Replace ⏎············"VerifiableCredential"⏎·········· with "VerifiableCredential"
test/fixtures/v4/tt/did-idvc-wrapped-wrong-binding.json|35 col 22| Replace ⏎··············"CorporateBasicDetails"⏎············ with "CorporateBasicDetails"
test/fixtures/v4/tt/did-idvc-wrapped-wrong-binding.json|129 col 2| Insert
test/fixtures/v4/tt/did-idvc-wrapped.json|6 col 12| Replace ⏎····"VerifiableCredential",⏎····"TradeTrustCredential"⏎·· with "VerifiableCredential",·"TradeTrustCredential"
test/fixtures/v4/tt/did-idvc-wrapped.json|28 col 20| Replace ⏎············"VerifiableCredential"⏎·········· with "VerifiableCredential"
test/fixtures/v4/tt/did-idvc-wrapped.json|35 col 22| Replace ⏎··············"CorporateBasicDetails"⏎············ with "CorporateBasicDetails"
test/fixtures/v4/tt/did-idvc-wrapped.json|129 col 2| Insert
test/fixtures/v4/tt/did-wrapped-signed.json|6 col 12| Replace ⏎····"VerifiableCredential",⏎····"TradeTrustCredential"⏎·· with "VerifiableCredential",·"TradeTrustCredential"
test/fixtures/v4/tt/did-wrapped-signed.json|92 col 2| Insert
test/fixtures/v4/tt/did-wrapped-signed2.json|6 col 12| Replace ⏎····"VerifiableCredential",⏎····"TradeTrustCredential"⏎·· with "VerifiableCredential",·"TradeTrustCredential"
test/fixtures/v4/tt/did-wrapped-signed2.json|92 col 2| Insert
test/fixtures/v4/tt/did-wrapped.json|6 col 12| Replace ⏎····"VerifiableCredential",⏎····"TradeTrustCredential"⏎·· with "VerifiableCredential",·"TradeTrustCredential"
test/fixtures/v4/tt/did-wrapped.json|90 col 2| Insert
test/fixtures/v4/tt/did-wrapped2.json|6 col 12| Replace ⏎····"VerifiableCredential",⏎····"TradeTrustCredential"⏎·· with "VerifiableCredential",·"TradeTrustCredential"
test/fixtures/v4/tt/did-wrapped2.json|90 col 2| Insert

Comment on lines 6 to 9
"type": [
"VerifiableCredential",
"TradeTrustCredential"
],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····"VerifiableCredential",⏎····"TradeTrustCredential"⏎·· with "VerifiableCredential",·"TradeTrustCredential"

Suggested change
"type": [
"VerifiableCredential",
"TradeTrustCredential"
],
"type": ["VerifiableCredential", "TradeTrustCredential"],

Comment on lines 28 to 30
"type": [
"VerifiableCredential"
],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎············"VerifiableCredential"⏎·········· with "VerifiableCredential"

Suggested change
"type": [
"VerifiableCredential"
],
"type": ["VerifiableCredential"],

Comment on lines 35 to 37
"type": [
"CorporateBasicDetails"
],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎··············"CorporateBasicDetails"⏎············ with "CorporateBasicDetails"

Suggested change
"type": [
"CorporateBasicDetails"
],
"type": ["CorporateBasicDetails"],

"privacy": {
"obfuscated": []
}
}
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert

Suggested change
}
}

Comment on lines 6 to 9
"type": [
"VerifiableCredential",
"TradeTrustCredential"
],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····"VerifiableCredential",⏎····"TradeTrustCredential"⏎·· with "VerifiableCredential",·"TradeTrustCredential"

Suggested change
"type": [
"VerifiableCredential",
"TradeTrustCredential"
],
"type": ["VerifiableCredential", "TradeTrustCredential"],

Comment on lines 28 to 30
"type": [
"VerifiableCredential"
],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎············"VerifiableCredential"⏎·········· with "VerifiableCredential"

Suggested change
"type": [
"VerifiableCredential"
],
"type": ["VerifiableCredential"],

Comment on lines 35 to 37
"type": [
"CorporateBasicDetails"
],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎··············"CorporateBasicDetails"⏎············ with "CorporateBasicDetails"

Suggested change
"type": [
"CorporateBasicDetails"
],
"type": ["CorporateBasicDetails"],

}
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert

Suggested change
}
}

Comment on lines 6 to 9
"type": [
"VerifiableCredential",
"TradeTrustCredential"
],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····"VerifiableCredential",⏎····"TradeTrustCredential"⏎·· with "VerifiableCredential",·"TradeTrustCredential"

Suggested change
"type": [
"VerifiableCredential",
"TradeTrustCredential"
],
"type": ["VerifiableCredential", "TradeTrustCredential"],

Comment on lines 28 to 30
"type": [
"VerifiableCredential"
],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎············"VerifiableCredential"⏎·········· with "VerifiableCredential"

Suggested change
"type": [
"VerifiableCredential"
],
"type": ["VerifiableCredential"],

@cavacado cavacado merged commit 1279340 into alpha Nov 23, 2023
5 checks passed
@cavacado cavacado deleted the feat/new-schemata branch November 23, 2023 05:32
Copy link

🎉 This PR is included in version 6.8.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant