New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PULPino port #58
PULPino port #58
Conversation
…entral_interrupt_handler
… mode, either in user mode
Hi I did a quick review. In file goil/templates/build/build_py.goilTemplate you added code if target is riscv. +cSourceList.append(projfile.ProjectFile("% !PROJECT %/tpl_vectors.c")) should be set using the OIL attribute GENERATED_FILE. Check the other targets in the templates/.../config hierarchy +% Maybe this kind of thing can use an additional OIL attribute like NEEDS_ENV in the templates/.../config hierarchy to list the environment variables needed. In build.py.goilTemplate, a test could be generated for each of these attribute. |
…on call to retrieve environment variable.
Believe it was the single root Trampoline file that I touched. |
Another idea to solve the second point would be to include PULPino's repo as a submodule to Trampoline. The submodule would be cloned only after a user request with Which solution do you think that works better with Trampoline ? Even with submodules Trampoline would still expect the user to "clone" PULPino and to run Regards. |
Hi ! In fact we may need some way to generate checks in the build.py with goil (and maybe a goil option to force them to a value). For the meantime, you can replicate the generation of the build.py file in goil/templates/build/riscv{/pulpino,}/ directory and do whatever you want in this file. Here's a patch that does this : 0002-pulpino-check-Add-PULPINO_PATH-environnment-variable.patch.txt Plus, you can add other architecture-dependant oil relative checking in the goil/templates/check/riscv{/pulpino,} directory. Here's a patch that returns an error if trying to use Memory or Timing protection : 0001-pulpino-check-Warn-if-trying-to-use-Memory-Timing-pr.patch.txt |
Hello, The patches were applied ! Regards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is ok for me
Hello, I merged the pull-request. Thank you very much for your contribution ! |
Solves issue #55.