Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binary_cross_entropy in functional.frontends.torch #2310

Merged
merged 21 commits into from
Aug 22, 2022
Merged

Add binary_cross_entropy in functional.frontends.torch #2310

merged 21 commits into from
Aug 22, 2022

Conversation

whitepurple
Copy link
Contributor

@whitepurple whitepurple commented Jul 26, 2022 •
edited
Loading

[updated] pr for #3037

  • binary_cross_entropy

  • add ivy/functional/frontends/torch/nn/loss_functions.py

    • implement 'binary_cross_entropy'

  • add ivy_tests/test_ivy/test_frontends/test_torch/test_loss_functions.py

    • implement 'test_binary_cross_entropy'

@whitepurple whitepurple changed the title add Frontend torch loss functions Add loss_functions in functional.frontends.torch Jul 31, 2022
@whitepurple
Copy link
Contributor Author

Hello @jiahanxie353 ,
This pull request is ready for review, including formatting.
The code was written with reference to torch.nn.functional,
and the warning that originally occurred in torch was omitted.

@whitepurple whitepurple changed the title Add loss_functions in functional.frontends.torch Add binary_cross_entropy in functional.frontends.torch Aug 7, 2022
@1Doomdie1 1Doomdie1 added Extension Ivy Functional API Next Release This issue or PR should only be considered once the next release is out. labels Aug 11, 2022
@sreegandh804 sreegandh804 removed Extension Next Release This issue or PR should only be considered once the next release is out. Ivy Functional API labels Aug 11, 2022
@whitepurple
Copy link
Contributor Author

Hello @jiahanxie353, @1Doomdie1, @sreegandh804.
Please review or give feedback on this pr so that I can work on the next one. Thanks.

jiahanxie353
jiahanxie353 reviewed Aug 21, 2022
View reviewed changes
Copy link
Contributor

@jiahanxie353 jiahanxie353 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, left comments below. Looks good to me in general!

ivy/functional/frontends/torch/loss_functions.py Outdated Show resolved Hide resolved
ivy/functional/frontends/torch/loss_functions.py Outdated Show resolved Hide resolved
@whitepurple
Copy link
Contributor Author

I have updated all the changes following the reviews.
The test code was verified by executing max_examples=1000 in conftest.py.

@jiahanxie353
Copy link
Contributor

I have updated all the changes following the reviews. The test code was verified by executing max_examples=1000 in conftest.py.

lgtm, I will merge it. Thanks a lot for contributing!

@jiahanxie353 jiahanxie353 merged commit f648e9e into ivy-llc:master Aug 22, 2022
@whitepurple whitepurple deleted the frontend_torch_loss_functions branch August 23, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiahanxie353 jiahanxie353 Awaiting requested review from jiahanxie353

Assignees

@jiahanxie353 jiahanxie353

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whitepurple @jiahanxie353 @1Doomdie1 @sreegandh804