-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tensorflow GatherNd raw_ops #27745
Conversation
Hi @he11owthere, Hope you are doing well, So, I had implemented GatherNd in raw ops for tensorflow. But the issue I am currently facing is that out of 5 tests sometimes 4 or 3 are passing. Would really appreciate if you could help me out with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @TalhaKhalil, correct me if I am wrong but I think indices
must have at least as many dimensions as the input tensor.
Try using these values:
min_num_dims=1,
max_num_dims=5,
min_dim_size=1,
max_dim_size=10,
indices_same_dims=True,
@he11owthere I changed these parameters in the test function but as of now none of the tests are passing |
For me, all the tests are passing with these values:
The issue is that indices are sometimes trying to access invalid dimensions since the overall shape of the tensor might differ for both the |
@he11owthere Can you tell me the the data types to be included along with the decorator |
You will have to run the tests and will face errors regarding unsupported data types like |
PR Description
Related Issue
Closes #27443
Checklist
Socials