Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed reciprocal_no_nan at tf frontend #28592

Merged
merged 1 commit into from
Mar 16, 2024
Merged

fix: fixed reciprocal_no_nan at tf frontend #28592

merged 1 commit into from
Mar 16, 2024

Conversation

samthakur587
Copy link
Contributor

@samthakur587 samthakur587 commented Mar 13, 2024 •
edited
Loading

fixed reciprocal_no_nan at tf frontend the tests are not passing at paddle backend.

passing all the test locally.

image

Closes #28591

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Mar 13, 2024
Ishticode
Ishticode approved these changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samthakur587 Thanks for the PR.
looks good for merge.
Does paddle have issue with values smaller then 1e-08?

@samthakur587
Copy link
Contributor Author

samthakur587 commented Mar 16, 2024 •
edited
Loading

@samthakur587 Thanks for the PR. looks good for merge. Does paddle have issue with values smaller then 1e-08?

yes at the paddle backend if the value is less then 1e-8 to it round it to zero. for that reason it giving inf for as the output.

@samthakur587
Copy link
Contributor Author

thanks for review @Ishticode i am merging this PR 🚀

@samthakur587 samthakur587 merged commit 26f97eb into ivy-llc:main Mar 16, 2024
129 of 153 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ishticode Ishticode Ishticode approved these changes

Assignees

@Ishticode Ishticode

Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix reciprocal_no_nan at tf forntend
3 participants
@samthakur587 @Ishticode @ivy-leaves