feat: implemented ifftshift and corresponding test #28707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ivy-leaves
added
the
JAX Frontend
VaishnaviMudaliar
changed the title
VaishnaviMudaliar
changed the title
|
@Ishticode Kindly review the code , all tests are passing now , however , if anymore changes are needed , kindly let me know 👍 |
|
|
Ishticode
suggested changes
Apr 8, 2024
There was a problem hiding this comment.
Hi Thanks for your patience @VaishnaviMudaliar
Below is a request
ivy_tests/test_ivy/test_frontends/test_jax/test_numpy/test_fft.py
Outdated
Show resolved
Hide resolved
I have generated the axis parameter as suggested by you by using dtype_values_axis helper function. The tests are passing. Kindly let me know if anymore changes are needed 👍 |
Ishticode
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Hi @VaishnaviMudaliar
This looks good now. Thank you very much for your effort and patience through this. Will merge this soon. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Related Issue
Closes #23801
Checklist
Socials