add concat #2989
Merged
add concat #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to frontends.torch
Closed
rush2406
suggested changes
Aug 16, 2022
There was a problem hiding this comment.
Hi @PatternFinder
Thanks for contributing! The changes look good to me, can you comment the issue here so that others don't assign it again, let me know once it's done and it's good to merge
ok I linked both cat and concat to its issue in the todo list please let me know if there is anything else that needs to be done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link to issue: #2621
concat is an alias of cat
add concat to frontends.torch