-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added kl_div frontend #9203
Added kl_div frontend #9203
Conversation
Also, may I have this request linked to my issue? I can't seem to find the settings icon to link to it by myself. My issue is #9183 |
@juliagsy may I ask for my current code progress to be reviewed? If there's like any additional bug I could fix as currently, the test case for the current kl_div I have pushed have been successful as of right now. |
Hey! Thanks for contributing! I'll review within the next 2 days! Meanwhile, could you please resolve the conflicts in the test file? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! Great work so far! Some changes related to test failures are needed, please request my review once again when you're done, thanks!
ivy_tests/test_ivy/test_frontends/test_torch/test_loss_functions.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! Thanks for the changes!
The tests for kl_div
are still failing, you may check the workflow for the failures, or you may run the tests locally by executing:
python3 -m pytest ivy_tests/test_ivy/test_frontends/test_torch/test_loss_functions.py::test_torch_kl_div
You should ensure that the tests for kl_div
are passing for all backends.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliagsy turns out the error I got is due to I forgot to add unsupported decorator for half precision. It should work fine now as it has passed all of the tests in my machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! will merge in soon!
Co-authored-by: juliagsy <67888047+juliagsy@users.noreply.github.com>
Co-authored-by: juliagsy <67888047+juliagsy@users.noreply.github.com>
Co-authored-by: juliagsy <67888047+juliagsy@users.noreply.github.com>
I was trying to add test cases and ran pytest on the
test_loss_functions.py
file, it seems when i try to run it certain functions in the helper likearray_or_none
does not exists which gave me an error while testing. I tried it on my other files for empirical testing and the results between original functionals forkl_div
should work as expected.closes #9183