Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added kl_div frontend #9203

Merged
merged 12 commits into from
Jan 15, 2023
Merged

Added kl_div frontend #9203

merged 12 commits into from
Jan 15, 2023

Conversation

zaRizk7
Copy link
Contributor

@zaRizk7 zaRizk7 commented Dec 29, 2022

I was trying to add test cases and ran pytest on the test_loss_functions.py file, it seems when i try to run it certain functions in the helper like array_or_none does not exists which gave me an error while testing. I tried it on my other files for empirical testing and the results between original functionals for kl_div should work as expected.

closes #9183

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Dec 29, 2022
@zaRizk7
Copy link
Contributor Author

zaRizk7 commented Dec 30, 2022

Also, may I have this request linked to my issue? I can't seem to find the settings icon to link to it by myself. My issue is #9183

@zaRizk7
Copy link
Contributor Author

zaRizk7 commented Jan 6, 2023

@juliagsy may I ask for my current code progress to be reviewed? If there's like any additional bug I could fix as currently, the test case for the current kl_div I have pushed have been successful as of right now.

@juliagsy
Copy link
Contributor

juliagsy commented Jan 8, 2023

Hey! Thanks for contributing! I'll review within the next 2 days! Meanwhile, could you please resolve the conflicts in the test file? Thanks!

Copy link
Contributor

@juliagsy juliagsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Great work so far! Some changes related to test failures are needed, please request my review once again when you're done, thanks!

Copy link
Contributor

@juliagsy juliagsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Thanks for the changes!

The tests for kl_div are still failing, you may check the workflow for the failures, or you may run the tests locally by executing:

python3 -m pytest ivy_tests/test_ivy/test_frontends/test_torch/test_loss_functions.py::test_torch_kl_div

You should ensure that the tests for kl_div are passing for all backends.
Thanks!

Copy link
Contributor Author

@zaRizk7 zaRizk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliagsy turns out the error I got is due to I forgot to add unsupported decorator for half precision. It should work fine now as it has passed all of the tests in my machine.

Copy link
Contributor

@juliagsy juliagsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! will merge in soon!

@juliagsy juliagsy merged commit 248b113 into ivy-llc:master Jan 15, 2023
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 23, 2023
Co-authored-by: juliagsy <67888047+juliagsy@users.noreply.github.com>
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
Co-authored-by: juliagsy <67888047+juliagsy@users.noreply.github.com>
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
Co-authored-by: juliagsy <67888047+juliagsy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kl_div
3 participants