Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curve25519 support #385

Merged
merged 8 commits into from
Jan 2, 2015
Merged

Curve25519 support #385

merged 8 commits into from
Jan 2, 2015

Conversation

NielsZeilemaker
Copy link
Contributor

Implemented curve25519 support for dispersy, members can be constructed from a curve25519 key. This paves the way for the tunnelcommunity swtiching to curve25519 keys.
It uses

Tested barebone signing/verifying using test_crypto, signing/verifying using test_member.

@NielsZeilemaker
Copy link
Contributor Author

I'm using the dual key modal, as explained here https://libnacl.readthedocs.org/en/latest/topics/dual.html this allows us to easily add encryption/descryption using the same keys.

@tribler-ci
Copy link

Merged build triggered.

@tribler-ci
Copy link

Merged build started.

@tribler-ci
Copy link

Merged build finished.

@tribler-ci
Copy link

Test FAILed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Dispersy_pull-request-tester_devel/815/

@NielsZeilemaker
Copy link
Contributor Author

@whirm the test fail due to the missing dependencies, could you fix those?

@NielsZeilemaker
Copy link
Contributor Author

@whirm ill commit a small change soon which improves te key_to_bin stuff.

@whirm
Copy link
Contributor

whirm commented Dec 29, 2014

@NielsZeilemaker done

@tribler-ci
Copy link

Merged build triggered.

@tribler-ci
Copy link

Merged build started.

@tribler-ci
Copy link

Merged build finished.

@tribler-ci
Copy link

Test FAILed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Dispersy_pull-request-tester_devel/816/

@NielsZeilemaker
Copy link
Contributor Author

@whirm still doesn't seem to work, it seems that the dispersy tests aren't running inside the venv

@whirm
Copy link
Contributor

whirm commented Dec 30, 2014

@NielsZeilemaker it doesn't seem to be packaged for Debian/Ubuntu. Let me see what options we have.

@NielsZeilemaker
Copy link
Contributor Author

Libsodium seems to be there https://launchpad.net/ubuntu/+source/libsodium

@whirm
Copy link
Contributor

whirm commented Dec 30, 2014

Yes, but not the python bindings. So we either package them and provide two .debs, add another submodule or just copy the files you need to our repo...

@whirm
Copy link
Contributor

whirm commented Dec 30, 2014

@NielsZeilemaker I think the best would be for you to add it as a submodule: https://github.com/saltstack/libnacl

@NielsZeilemaker
Copy link
Contributor Author

I'll have a go

@NielsZeilemaker
Copy link
Contributor Author

@whirm I failed, i'm not able to get it to work. I'm stuggeling with the additional folders in the repo. Do you have any pointers?

@whirm
Copy link
Contributor

whirm commented Dec 30, 2014

I would just add the module dir to the pythonpath manually

@NielsZeilemaker
Copy link
Contributor Author

Tried that, failed as well

@whirm
Copy link
Contributor

whirm commented Dec 30, 2014

@NielsZeilemaker sent you a pull request

@tribler-ci
Copy link

Merged build triggered.

@tribler-ci
Copy link

Merged build started.

@tribler-ci
Copy link

Merged build finished.

@tribler-ci
Copy link

Test FAILed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Dispersy_pull-request-tester_devel/817/

@NielsZeilemaker
Copy link
Contributor Author

@whirm almost, now it can find libsodium

OSError: Could not locate nacl lib, searched for libsodium.so, libsodium.so.13, libsodium.so.10, libsodium.so.5, libsodium.so.4,  and tweetnacl.so

@whirm
Copy link
Contributor

whirm commented Dec 31, 2014

retest this please

@tribler-ci
Copy link

Merged build triggered.

@tribler-ci
Copy link

Merged build started.

@tribler-ci
Copy link

Merged build finished.

@tribler-ci
Copy link

Test FAILed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Dispersy_pull-request-tester_devel/818/

@tribler-ci
Copy link

Merged build triggered.

@tribler-ci
Copy link

Merged build started.

@tribler-ci
Copy link

Merged build finished.

@tribler-ci
Copy link

Test FAILed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Dispersy_pull-request-tester_devel/819/

@NielsZeilemaker
Copy link
Contributor Author

retest this please

@NielsZeilemaker
Copy link
Contributor Author

@whirm its failing due to pylint checking libnacl, i'm trying to remove those files from pylint. If this attempt doesn't work, i'll let you fix it.

@tribler-ci
Copy link

Merged build triggered.

@tribler-ci
Copy link

Merged build started.

@tribler-ci
Copy link

Merged build finished.

@tribler-ci
Copy link

Test PASSed.
Refer to this link for build results: http://jenkins.tribler.org/job/GH_Dispersy_pull-request-tester_devel/820/

@whirm
Copy link
Contributor

whirm commented Jan 2, 2015

@NielsZeilemaker is it ready?

@NielsZeilemaker
Copy link
Contributor Author

Jup

2015-01-02 11:50 GMT+01:00 Elric Milon notifications@github.com:

@NielsZeilemaker https://github.com/NielsZeilemaker is it ready?


Reply to this email directly or view it on GitHub
#385 (comment).

whirm added a commit that referenced this pull request Jan 2, 2015
@whirm whirm merged commit 9d63d68 into Tribler:devel Jan 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants