Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle button to control anonymity in the download dialog #4854

Closed
ichorid opened this issue Sep 23, 2019 · 3 comments
Closed

Add toggle button to control anonymity in the download dialog #4854

ichorid opened this issue Sep 23, 2019 · 3 comments

Comments

@ichorid
Copy link
Contributor

ichorid commented Sep 23, 2019

There are two problems with our "Download torrent" dialog window:

  1. Anonymity control is done by a small checkbox that is hard to notice. Instead, the current anonymity mode should be instantly visible and toggleable.
  2. DHT requests go through the regular connection, which are observable (see Full anonymity on torrent download #4021). Instead, if anonymity is on, the DHT request should go through the tunnels as well. But if the user toggles anonymity mode, the DHT request should be immediately sent again directly. This is non-intuitive with the checkbox.

The solution is to use a toggle button, like this:
LHLiq

One implementation of a toggle control in pure QT: https://stackoverflow.com/a/51825815/5553928

The button for anonymity should be "ON" by default, and the file list dialog should show a ticker with time till DHT request timeout. As soon as the timeout is reached, a suggestion to try the request again in non-anonymous mode should be shown to the user.

@hbiyik
Copy link

hbiyik commented Sep 24, 2019

for 2: %100 agree, I was trying to tweak out this behavoir for a while, but the code is still to complex for my mortal brain. tunnel dht please

@ichorid
Copy link
Contributor Author

ichorid commented Apr 9, 2020

Well, turned out tunneled DHT requests are very unreliable. This makes adding this toggle control top priority, so users who do not use anonymity will not suffer from bad DHT performance over the tunnels.

@qstokkink
Copy link
Contributor

This should be resolved now: anonymity is on by default and metadata retrieval when adding torrents should be tunneled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants