Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop build at first failure #5

Closed
GPMueller opened this issue Mar 9, 2018 · 3 comments
Closed

Stop build at first failure #5

GPMueller opened this issue Mar 9, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@GPMueller
Copy link
Contributor

Currently the program may continue to run for quite a while, trying to build parent targets of the failed target.
@NOhs
Copy link
Collaborator

NOhs commented Apr 1, 2018

In my current branch I topologically sort the targets in the dependency graph and go through it target by target. So we could abort as soon as a target fails.

@GPMueller
Copy link
Contributor Author

It could suffice to simply not call the parent's compile function (and to not set compiled = True, when the failure of a build command is detected, as this would automatically keep any parent from being compiled.

@GPMueller GPMueller added the enhancement New feature or request label Apr 2, 2018
@GPMueller
Copy link
Contributor Author

With PR #23, merged with a7bbc88, it has been implemented that sources are built as far as possible and at link-time, the build is stopped when a target is encountered, containing sources that were not able to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GPMueller @NOhs