Comment and code contradict each other

[NOhs]

Looking at the following code:

clang-build/clang_build/target.py

Lines 76 to 80 in c5d5c1b

	# Header only include directories are always public
	if target.__class__ is HeaderOnly:
	self.include_directories += target.include_directories
	self.include_directories += target.include_directories_public

We see that while the comment says that header only targets' include directories are always public, this is not realized in the actual code, hence requiring this unnecessary check to then also include the "non-public" include directories of header only targets.

[GPMueller]

You mean the headeronly target should not have any flags in the non-public member variable? The comment refers to the behaviour the user should experience.

[NOhs]

The header only target should have all include_directories in the self.include_directories_public so it behaves as the user experiences it and does not require some extra treatment. It is not a bug, more like a design issue imho.

[GPMueller]

Agreed, this would be better. There might be some places in the init that need changing, I think some defaults are placed in those variables for all target kinds.

[NOhs]

I am currently trying to get an overview of the init function, I think it can be simplified a bit and at the same time the above mentioned can be implemented.

[NOhs]

Should be "fixed" with #76