[DK] Bug Crypt Fever+Ebon Plaguebringer

[thiagogcunha]

Well today I realized that the talents and Crypt Fever Ebon Plaguebringer are being added on the target. If you have 4 dk's in your raid or party buffs will increase the damage by adding 120 / 80.

Crypt Fever 120%
30% Ebon Plaguebringer

http://www.wowwiki.com/Crypt_Fever
http://www.wowwiki.com/Ebon_Plaguebringer

[Greymane]

Well, i can confirm that, put 25 DK's on your raid and you will have wooping 30-40k or more disease ticks :O

Also devouring plague is beign affected by this issue too

Core rev: cb9985c
DB: TDB 41 + updates

[kbinside]

confirmed.

[overy]

confirm

[Odilon]

Confirm
Core rev: feb3d9c
DB: TDB 41 + updates

[d7561985]

problem comes from bb0634c
Thise commite are very dungerous. Not all auras should be multiplicative. Auras with one rank line shoul applyed only ones, highest.

[Greymane]

i'm using this workaround to live with it https://github.com/Greymane/ChaosCore/commit/a0e63c3b4a210cf95e74129349f58e8f73c1a260

The strange is that this only happens to ebon plague, i hadn't saw any other issue of this kind elsewhere.

[d7561985]

u patch jast kill using of Ebon Plague at all. :)

• where are a lot problems after bb0634c too not only Ebon

[kbinside]

this need to be fixed, couse now classes that gets benefit from sp do insane dps.

[Greymane]

@cyberbrest, no it didnt killed ebon plague at all, you should test it before saying something like that.

The only problem with that patch is that Ebon plague bonus spell damage will be given only to the Ebon plague owner' spells, no longer to the entire raid.

[d7561985]

sorry, u right. But it's just a little hack fix which not fix all problems in that commite. For correct fix we shoul apply auras to damage only for diffrent rank-tree spell. For it we could do something like conteinter

std::map<uint32 apply_first_rank_spell, uint32 curent_aura_amount>

• check every aura and insert to conteiner. if we already insert to conteiner check aura amount if current higher so change it on conteiner.
  It's only what i could imagine, BUT IT VERY SLOW, for using it on moste usible operation, and allocation, insertion, replasion it very expensive. So, i just revert bb0634c and think about enother way to do multiplication for SPELL_AURA_MOD_DAMAGE_PERCENT_TAKEN

[steel2p]

SpellMgr.cpp

       case 51735: // Ebon Plague
        case 51734:
        case 51726:
            spellInfo->AttributesEx3 |= SPELL_ATTR3_STACK_FOR_DIFF_CASTERS;
            spellInfo->SpellFamilyFlags[2] = 0x10;
            break;
        case 41913: // Parasitic Shadowfiend Passive

Comment or remove:
spellInfo->AttributesEx3 |= SPELL_ATTR3_STACK_FOR_DIFF_CASTERS;

Make SQL files with spell_group and etc if you want to perfect it out, so it does not stack with Crypt Fever too.
And yes, it's a hack. But more importantly, getting the job done hack for me.

[Ric101]

Neh, not really, since most Dk skills benefict from numbers of diseases (3 with that one)

[steel2p]

As far as I know and can read STACK_FOR_DIFF_CASTERS is for stacking with different casters, not numbers of deseases, but nevermind, do as you please. And I mentioned it's a hack.

[Star-lion]

how is it a hack? that line shouldnt actually be there as it is not supposed to stack for different casters?

[Greymane]

@Kandera, STACK_FOR_DIFF_CASTERS is an attribute used to allow auras with same ID be applyed multiple times on the same target even if they are casted from different casters. Removing this attribute will screw up raids with more than 1 Unholy DK on the group, since every time they use plague strike, icy touch, or glyphed pestilence to reapply their diseases, they will replace the other's dks ebon plague with their own.

[Star-lion]

but that shouldnt really matter as the buff applies to ALL diseases on the target not just your disease damage so it wouldnt matter who has the buff up itll be the same effect all the time wouldnt it?

[Expecto]

It also should staks the author drink to poison

[ghost]

it is still bugged? after f9b0cdd#commitcomment-753476

[Jeidai]

any fixes?

[telsamat]

this make Dk very OP, Kandera can you look at this please ? :)

[Hispano]

still bugged, rev ca8862a

[Muzashi]

There are some DK spells that do more damage deppending on the number of diseases on the target, like Scourge Strike and Obliterate. If another DK removes your Ebon Plaguebringer or Crypt Fever with his, you'll do less damage with those spells because you loss your disease.

I think that STACK_FOR_DIFF_CASTERS should be there

[telsamat]

can someone test this sinakal@cffdaca ?

[Hispano]

tested and works though there can only be one Ebon Plaguebringer aura on the target applied at time, but IMO it is better than commenting this line //spellInfo->AttributesEx3 |= SPELL_ATTR3_STACK_FOR_DIFF_CASTERS;

[Star-lion]

that is a horrible way to do it as ebon plaguebringer/crypt fever is also a disease so it adds dps for the dk that uses it.

[telsamat]

what about this fix https://github.com/Elron103/TrinityCore/commit/2a8f71123daa8afa7482cbf8931a4a482a9b47ed?

[Star-lion]

it would work BUT that stack rule isnt working correctly

[telsamat]

the another super bug is with improved devouring plague, it makes with ebon this spell very OP

maybe it is bug with Ebon stack itselfs

[Star-lion]

uhhh. i dont understand what you are saying this time.

[telsamat]

sry :D #4203 this bug is related to Ebon too

the main fail is here :

for each DK=this is the OP bug, test it yourself with 10 DK with ebon plaguebringer in raid group and 1 shadow priest

I have had sh priest around 2000 power , haste around 820, without any buffs, I deal with IDP around 2000 without Dk in raid, with 1DK it was around 3200, with 2 DKs 4300, with 3DKs 5600 etc.

[Star-lion]

yes this is causing that issue. its only with ebon plague and not with idp

[Ze70R]

Also Ebon plague doesnt give those 3% crit chance on all abilites,or atleast those 3% are not seen at char stats which is wrong.

[Star-lion]

are you sure it should be shows on the char stats?

[Ze70R]

Updated to f4c8f6e works as it shoud.The pasive aura for the 3% is applied correctly

[mweinelt]

We are currently using this for stacking, so neither rank of crypt fever nor one of ebon plague can be on the same target at one time. It is failing for some reason, though....and I can't see why :(

DELETE FROM spell_ranks WHERE first_spell_id IN (51726, 50508);
INSERT INTO spell_ranks (first_spell_id, spell_id, rank) VALUES
(51726, 51726, 1), -- ebon plague
(51726, 51734, 2),
(51726, 51735, 3),
(50508, 50508, 1), -- crypt fever
(50508, 50509, 2),
(50508, 50510, 3);

SET @group := 1118;
DELETE FROM spell_group WHERE id = @group;
INSERT INTO spell_group (id, spell_id) VALUES
(@group, 50508),
(@group, 51726);

DELETE FROM spell_group_stack_rules WHERE group_id = @group;
INSERT INTO spell_group_stack_rules (group_id, stack_rule) VALUES
(@group, 1);

(obv. rule1 is not blizzlike, but it would be better than unholy deathknights doing like 35-40k dps on champions encounter in ToC25)

[LuqJensen]

the above sql doesnt fix ebon plaguebringer, the problem is that the ebon plaguebringer uses two serverside scripts in one effect, adding both 13% magic dmg done and 30% to diseases. As this being one effect it isnt limited to the crypt fever fix and the ebon plague ids themselves are just the "talent spell ids" whereas cryptfever has 2 ids per rank one for "talent spell ids" and then the correct one "debuff spell ids" which is missing for ebon plaguebringer, as it is a serverside script. This fix below does exactly the same as your fix, mweinelt.

DELETE FROM spell_ranks WHERE first_spell_id = 50508;
INSERT INTO spell_ranks (first_spell_id, spell_id, rank) VALUES
(50508, 50508, 1), -- Crypt Fever
(50508, 50509, 2),
(50508, 50510, 3);

DELETE FROM spell_group WHERE id = 1151;
INSERT INTO spell_group (id, spell_id) VALUES
(1151, 50508); -- Crypt Fever

DELETE FROM spell_group_stack_rules WHERE group_id = 1151;
INSERT INTO spell_group_stack_rules (group_id, stack_rule) VALUES
(1151, 1); -- Exclusive, Same Effect doesn't work :(

The problem is that some serverside script for ebon plague is overriding this rule. so unless someone can implement the debuff spell ids for ebon plague manually, it must be fixed within the core

Edit1: above context is thoroughly tested by me and Lat89 on my 333.50 server

[Zedron]

Had an ICC 25 heroic group with 11 Death Knights kill Blood Prince Council in ~a minute... top DPS was 109k (a death knight)
can anyone confirm if this has been fixed yet?

[Aokromes]

#4313

[Demonid]

Still bugged on e8df8ff

Hope @Trisjdc can fix this too =P