Complete list of buffs and debuffs with stacking issues

[Lat89]

Googling through closed and opened issues, all i could find were either uncomplete/inaccurate reports of this problem, or only a few spells being reported 1 by 1. Anyway i decided to make a complete list of buffs/debuffs which stack with similar or same buffs, though they shouldn't.
NOTE: ID's of following spells are showing their max ranks.

Leader of the Pack[17007] stacks with Rampage[29801], which is 10% increased melee and ranged crit chance instead of 5%.

Totem of Wrath[57722], the spellpower buff this spell provides stacks with Demonic Pact[47240], giving huge amount of spellpower. Shouldn't.

Flametongue Totem[58656], the spellpower buff this spell provides stacks with Demonic Pact[47240].

Sanctified Retribution[31869] stacks with Arcane Empowerment[31583] again stacking with Ferocious Inspiration[34460], giving increased damage to party/raid members, calculated 1,03 x 1,03 x 1,03~1,927 which is 9,27% increase to damage done, instead of 3%. Lots of boost there. Furthermore, Sanctified Retribution stacks with itself, depending on how many different auras are retri paladins using, while having this talent.

Swift Retribution[53648] stacks with Improved Moonkin Form[48396], 6% haste instead of 3%. Also, just like Sanctified Retribution, Swift Retribution stacks with itself.

Greater Blessing of Kings[25898] stacks with Greater Blessing of Sanctuary[25899], well, stamina and strength parts stack and they shouldn't, adding 1,1 x 1,1=1,21; 21% to stamina/strength instead of 10% to both.

Crypt Fever[49632], which is actually a part of Ebon Plaguebringer[51161] stacks with itself(only the disease part stacks, 13% magic damage taken is fine). 2 unholy deathknights in a party/raid equals 1,3x1,3=1,69; 69% increased disease damage done, instead of regular 30%.Calculate yourself how much increase 10 UH dks in a raid would give.

That's all, rest of the buffs/debuffs arent bugged, example Mangle[48566] works fine when applied with Trauma[46857].
Importancy of these bugs is obviously large, as every TC based wotlk server has imbalanced raids, with cataclysm-ish numbers of damage due to these stacking issues.

http://www.wowpedia.org/Buff#Buffs.2C_debuffs.2C_and_raid_stacking_in_WotLK may help understanding the issue. List is for 3.0.2, but its basicly the same for 3.3.5, with a few added spells.

One thing that may help fixing this thing is 89bae3b It was used back when Curse of Elements/Earth and Moon/Ebon Plaguebringer were stacking. And most of the aforementioned spells stack in the same way.

Core up to b8d55cc , no custom fixes.

[Poli93]

Confirmed

[Star-lion]

http://www.warcrafthuntersunion.com/2009/05/list-of-what-raid-buffs-stack-and-do-not-stack/

also that stack rule doenst work for some reason

[lendan]

Confirmed
You should mention which buffs should be active.. like for example
Leader of the Pack[17007] stacks with Rampage[29801], which is 10% increased melee and ranged crit chance instead of 5%.

Leader of the pack should be active since it heals whenever u crit and rampage doesnt which makes LotP way better

Bok and BoS,when those two are up on player,only BOK should grant 10% to all stats and bos part which grants 10% str and stamina should not work BUT bos also reduce damage taken by 3% and gives ya mana back on block/dodge/parries etc and this part should work whenever BOK is up

[Lat89]

That link you added is also outdated and not for 3.3.5 Kandera xD but anyway most of the things are the same..my list is complete.
AND that stack rule fixed CoE/EaM/EP stacking problem we had, and now those spells work just fine adding a magic debuff of 13% instead of 1,13x1,13x1,13=44%.. Sry but got to ask, are you really sure it doesn't work?

lendan i would but im not sure which spells should overwrite others..Afaik Demonic Pact has the advantage over Totem of Wrath only if warlock's SP is over 2800, meaning that more powerful spells are shown as your buffs while weaker are hidden, but i could be wrong about this.

[lendan]

Yeah you're right about pact,heard about that too but i have no clue about casters so.. ITS GOOGLE TIME,gonna edit this post if i find anything useful.

Can't find anything,will post on other forum maybe someone can provide sum kewl info.
This stacking rule,would be awesome if someone can look at that,those stacking buffs increase dmg a lot

Btw,Swift Retribution[53648] stacks with Improved Moonkin Form[48396], 6% haste instead of 3%. what about shammy totem of air which increase haste,should it stack?

Kandera: I see,thanks for info ;p

[Star-lion]

all these using that stack rule will automatically use the HIGHEST value of those effect types

[Lat89]

What do you mean by that? Highest as.. if you for example got Improved Scorch(5% spellcrit), and Winter's Chill applied to the target 4 times(4% spellcrit), result will be 9% spellcrit debuff, OR 5% as in, scorch is that "highest value".. Sry for dumb questions but i dont get it.

[Subv]

With 20ca59f you should be able to fix "Improved Scorch[ID 12873] stacks with Improved Shadow Bolt[17803] again stacking with Winter's Chill[28593] therefore giving you 15% increased spell critical chance instead of 5%." and maybe some others. Please test the stack rule again, @Kandera

[Lat89]

Just adding that 20ca59f didnt fix anything, stacking is still present

[Lat89]

#7881 has nothing to do with this btw

[Subv]

@Lat89 Fixed Improved Scorch, Improved Shadow Bolt and Winter's Chill stacking, removing them from the list

[Aokromes]

and this is why posting every bug on a single ticket is bad.

[Subv]

"Blood Frenzy[29859] stacks with Savage Combat[58413], 8% to physical damage instead of 4%." Fixed.

[Subv]

SET @GROUP := XXX;
-- Sanctified Retribution, Arcane Empowerment and Ferocious Inspiration effect should not stack
DELETE FROM `spell_group` WHERE `id`=@GROUP;
INSERT INTO `spell_group`(`id`,`spell_id`) VALUES
(@GROUP,75446),
(@GROUP,75447),
(@GROUP,75593),
(@GROUP,63531),
(@GROUP,31579);

DELETE FROM `spell_group_stack_rules` WHERE `group_id`=@GROUP;
INSERT INTO `spell_group_stack_rules`(`group_id`,`stack_rule`) VALUES (@GROUP,3);

I post it here for archive, but SPELL_AURA_MOD_DAMAGE_PERCENT_DONE handling needs to be changed in order for this to work.

[Subv]

"Totem of Wrath[57722], the debuff part of this spell (3% crit chance) stacks with Heart of the Crusader[20337], that's 6% crit chance debuff instead of 3%." Fixed

[Lat89]

Great job Subv, keep it up :)

[Morgoporc]

Some news for Sanctified Retribution, Arcane Empowerment and Ferocious Inspiration ?

[Subv]

@Morgoporc Will require a tad bit of a rewrite in the handling of their aura type.

[Lat89]

Updated the first post and added that Flametongue Totem stacks with Demonic Pact, same way Totem of Wrath does. However, Flametongue Totem doesnt stack with Totem of Wrath, theyre using a rule of "first one being summoned provides the buff, 2nd one is ignored". It shouldnt be working like this, Wrath one is more powerful therefore players should be gaining spellpower from this totem only. But ofc in a raid everyone will just desummon FT and use ToW so this isnt a big issue. What i propose is, perhaps check the stacking rule of FT---ToW, and come up with something similar for FT---DP and ToW---DP, using the same "first one being cast is active, 2nd one is ignored" rule, as a temporary solution.

[raynar]

I think I could help.

what are the current stacks bugs?

[Lat89]

@raynar Just read the first post.

[Morgoporc]

A question, when a retribution paladin (with Heart of the Crusader) and an elemental Shaman are in the same raid, if the Shaman summon the ToW, can you tell me if the spell power bonus is correctly applied on the paladin ?

[Lat89]

@Morgoporc Nice observation, the paladin doesnt gain any spellpower from the totem.
Also, ive updated the first topic and added that ever since Sanctified Retribution and Swift Retribution talents got fixed and work with all of the paladin's auras, they stack with themselves, so if you got 2 ret palas with aforementioned talents and 2 different auras on, that'd be 6% to damage done/speed increase. Problems everywhere D:

[Lat89]

fef854e was supposed to fix GboS/GboK stacking but it didnt, they're still bugged.

[Lat89]

Any news? Or patch-fixes?

[ghost]

confirm,still bugged:) obviously spell stack rule 3 doesnt work...dunno why

[Lat89]

Gbos-Gbok fix:

DELETE FROM spell_group WHERE id = 1138;
INSERT INTO spell_group (id, spell_id) VALUES
(1138, 72586), -- forgotten kings
(1138, 67480), -- blessing of sanctuary 10% stats id
(1138, 25898), -- greater blessing of kings
(1138, 20217); -- blessing of kings


DELETE FROM spell_group_stack_rules WHERE group_id = 1138;
INSERT INTO spell_group_stack_rules (group_id, stack_rule) VALUES
(1138, 1);

Looks like someone missed the actual BoS ID which concerns 10% stats modification [67480]. It will remove the strenght/stamina stacking though there's only one problem, BoK will have to be cast after BoS is already on the target, else BoS removes both buffs. A stacking rule needs to be changed in order for that to be fixed.

Flametongue totem/Totem of Wrath - Demonic Pact fix:

DELETE FROM spell_ranks WHERE first_spell_id = 57658;
DELETE FROM spell_ranks WHERE first_spell_id = 52109;
INSERT INTO spell_ranks (first_spell_id, spell_id, rank) VALUES
(57658, 57658, 1), -- Totem of Wrath
(57658, 57660, 2), 
(57658, 57662, 3),
(57658, 57663, 4),
(52109, 52109, 1), -- Flametongue Totem
(52109, 52110, 2),
(52109, 52111, 3),
(52109, 52112, 4),
(52109, 52113, 5),
(52109, 58651, 6),
(52109, 58654, 7),
(52109, 58655, 8);

DELETE FROM spell_group WHERE id = 1045; -- Old Flametongue totem group
DELETE FROM spell_group WHERE id = 1046; -- Old Totem of wrath group
DELETE FROM spell_group WHERE id = 1047; -- Old Demonic pact group
DELETE FROM spell_group WHERE id = 1048; -- Connection group of the three above
DELETE FROM spell_group WHERE id = 1145;
DELETE FROM spell_group WHERE id = 1146;
DELETE FROM spell_group WHERE id = 1147;
DELETE FROM spell_group WHERE id = 1149;
DELETE FROM spell_group WHERE id = 1150;
INSERT INTO spell_group (id, spell_id) VALUES
(1145, 57658), -- Totem of Wrath (Spellpower Part)
(1146, 52109), -- Flametongue totem
(1147, 48090), -- Demonic pact
(1149, -1145), -- Referral to ToW 
(1149, -1146), -- Referral to FT 
(1150, -1147), -- Demonic Pact
(1150, -1149); -- Referral to ToW+FT stacking rule


DELETE FROM spell_group_stack_rules WHERE group_id = 1046; -- Old Totem of wrath stacking rule
DELETE FROM spell_group_stack_rules WHERE group_id = 1048; -- Connection group stacking rule is set to 1 per standard, should be 3 after applying rule for ToW and Ft
DELETE FROM spell_group_stack_rules WHERE group_id = 1145;
DELETE FROM spell_group_stack_rules WHERE group_id = 1146;
DELETE FROM spell_group_stack_rules WHERE group_id = 1147;
DELETE FROM spell_group_stack_rules WHERE group_id = 1149;
DELETE FROM spell_group_stack_rules WHERE group_id = 1150;
INSERT INTO spell_group_stack_rules (group_id, stack_rule) VALUES
(1145, 1), -- Totem of wrath will not stack with itself
(1146, 1), -- Flametongue totem will not stack with itself
(1147, 1), -- Demonic pact will not stack with itself
(1149, 1), -- Totem of wrath will not stack with flametongue totem
(1150, 1); -- Totem of wrath and flametongue totem will not stack with demonic pact (totem aura will still be the first one placed though, as spell prios arent present in TDB)

This method doesnt work for Leader of the Pack/Rampage for some reason, though we used it to fix Cryptfever stacking, but whenever you spec into Ebon Plaguebringer its messing it up, cause it needs to be modified within the core, as @Unholychick explained it in #2706 where you can see the code (Props to him for helping with this!)

Everything has been tested and working on clean TC with a rev of d4398ea

Now i need a volunteer to create a pull request :)

[Lat89]

DELETE FROM spell_ranks WHERE first_spell_id = 75593;
DELETE FROM spell_ranks WHERE first_spell_id = 31579;
INSERT INTO spell_ranks (first_spell_id, spell_id, rank) VALUES
(75593, 75593, 1), -- Ferocious inspiration
(75593, 75446, 2),
(75593, 75447, 3),
(31579, 31579, 1), -- Arcane empowerment
(31579, 31582, 2),
(31579, 31583, 3);

DELETE FROM spell_group WHERE id = 1470;
INSERT INTO spell_group (id, spell_id) VALUES
(1470, 75593),
(1470, 31579),
(1470, 63531); -- retri aura can still be used to gain double benefit (seems like old buggy code remained in core when Sanctified retribution was "fixed")

DELETE FROM spell_group_stack_rules WHERE group_id = 1470;
INSERT INTO spell_group_stack_rules (group_id, stack_rule) VALUES
(1470, 1);

Prevents the stacking of multiple paladin auras/arcane empowerment/ferocious inspiration.

[emptyus]

I was wondering about faerie fire. Improved Faerie Fire is supposed to be stronger than Faerie Fire (feral) making it feral FF not apply-able on targets affected by IFF. This is not the case currently since ferals can infact do so, but I'm still not sure weather this is blizzlike 3.3.5a. I do remember ferals not being able to apply FF when IFF is on with the message of "A more powerful
spell is already active", tho idk what patch :< Any1 have a clue to this? Can't find solid proof...

[Morgoporc]

I guess that Dalaran Brillance stacks with Fel Intellect.

[digz6666]

It will be great if someone push working things to master :)

[LuqJensen]

it doesnt Morgoporc

[Aokromes]

Anyone can put all the fixes on a single post?

[Aokromes]

#4313 (comment)