Core/Spells: Fix redundant mod charge drop and spell crit calc #16186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng dropped twice. Closes TrinityCore#7315
ariel-
changed the title
|
Work \o/ |
|
Note that this will fix only duplicated modSpell consuming, there is still issue of Aura stacks not synchronizing properly with the charges. Detailed explanation in #15529 (comment) |
|
could a solution to the other issue require to revert this PR ? maybe it's better to find a solution for all the cases ? |
|
Not necessarily, IsSpellCrit is more than an observer, it calculates crit chance for a spell using active crit spellmods, and in doing so removes the charge from the spellmod. This PR only replaces the (extra, IMO) call to IsSpellCrit, using member TargetInfo::crit, this member is already initialized with proper value (crit or not), as stated, in Spell::DoAllEffectOnLaunchTarget() |
jackpoz
added a commit
that referenced
this pull request
Jan 9, 2016
Core/Spells: Fix redundant mod charge drop and spell crit calc
This was referenced Jan 9, 2016
Carbenium
pushed a commit
that referenced
this pull request
Jan 20, 2016
Core/Spells: Fix redundant mod charge drop and spell crit calc (cherry picked from commit b39216e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that critical is already calculated in Spell::DoAllEffectOnLaunchTarget()