Core/UnitAI: Rework creature-controlled player behavior. #16644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treeston
force-pushed
the
3.3.5-customcharmai
branch
from
252e5f9
to
7082e7d
Compare
3 tasks
Treeston
force-pushed
the
3.3.5-customcharmai
branch
4 times, most recently
from
7bb8b79
to
0c978e4
Compare
|
This is for creatures that charm players right? Charmed players blow their cooldowns, this should also be implemented in this commit. |
|
For now I want to merge a basic generic player AI that works. After that, we can iterate easily on this to create smarter charmed player behavior. |
|
This will be fix on future? #15379 --Edit Treeston you are my hero ! |
|
Yes, that's what I'm referring to for future iterations. |
| @@ -1022,6 +1023,8 @@ class Player : public Unit, public GridObject<Player> | |||
| explicit Player(WorldSession* session); | |||
| ~Player(); | |||
|
|
|||
| PlayerAI* AI() const { return (PlayerAI*)i_AI; } | |||
There was a problem hiding this comment.
Treeston
force-pushed
the
3.3.5-customcharmai
branch
2 times, most recently
from
bbd9581
to
16ddde4
Compare
|
Change summary:
|
Treeston
force-pushed
the
3.3.5-customcharmai
branch
from
16ddde4
to
434a894
Compare
|
Looks good, well done |
Treeston
force-pushed
the
3.3.5-customcharmai
branch
3 times, most recently
from
125e7f5
to
2f14664
Compare
- Removed hacked control mechanism, use proper PlayerAI instead
- Port old hacky code to new SimpleCharmedPlayerAI class
- Make adjustments to aforementioned code to fix bugs:
- Properly clean up movement after charm ends
- Only try to attack a target if charmer is engaged in combat
Treeston
added a commit
that referenced
this pull request
Feb 24, 2016
Core/UnitAI: Rework creature-controlled player behavior.
This was referenced Feb 24, 2016
|
Spells! We need Spells! 🎯 |
|
Sure, once we figure out #16687 so it looks less stupid when I make them cast. |
| } | ||
| } | ||
|
|
||
| std::cout << "Selected " << rangedAttackSpell << std::endl; |
There was a problem hiding this comment.
Already fixed in 1fbe797
Shauren
pushed a commit
that referenced
this pull request
Apr 8, 2016
Core/UnitAI: Rework creature-controlled player behavior. (cherry picked from commit 4e4b2b9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core/UnitAI: Rework creature-controlled player behavior.
Fixes #4723.