Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

fix(notification): update to empty notification to fix typo #346

Merged
merged 2 commits into from
Dec 18, 2018

Conversation

andrewleyva
Copy link
Collaborator

update to empty notification to fix typo where 'name' was used instead of 'className'

problem statement

SUIR violation
noted in #333 "uses class bell_icon, which violates SUIR's propTypes-like-thing"

solution

fix typo 'name' should be 'className'

fixes #333

@andrewleyva andrewleyva changed the title update to empty notification to fix typo fix(notification): update to empty notification to fix typo Dec 18, 2018
Copy link
Contributor

@bespokebob bespokebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"name" is correct for the properties SUIR is expecting. I'm not sure where the extra bell_icon class is used, but this is probably supposed to be:
<Icon name="bell outline" className="bell_icon" />

@andrewleyva
Copy link
Collaborator Author

Oh yeah, I think you're right. I refactored this too quickly.

@ggascoigne
Copy link
Member

Woohoo! new surge deployment available for viewing! 🎉 surgereviewlnjpdbwxrwzgivp.surge.sh

@andrewleyva andrewleyva merged commit 2d42224 into master Dec 18, 2018
@andrewleyva andrewleyva deleted the feat/notif-empty branch December 18, 2018 22:36
@ggascoigne
Copy link
Member

🎉 This PR is included in version 15.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suir prop-type warning on bell icon
3 participants