Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MantaHTTPSuite needs updating for new router #10

Open
tgross opened this issue Nov 14, 2016 · 1 comment
Open

MantaHTTPSuite needs updating for new router #10

tgross opened this issue Nov 14, 2016 · 1 comment

Comments

@tgross
Copy link
Contributor

tgross commented Nov 14, 2016

Much like as in an issue with gomanta the test suite was not updated with the new router that was added in f676d62. So currently the tests fail for what are problems with our test harness rather than the library.

go test ./...
# github.com/joyent/gocommon/testing_test
testing/httpsuite_test.go:40: not enough arguments in call to s.HTTPSuite.Mux.Handle
testing/httpsuite_test.go:52: not enough arguments in call to s.HTTPSuite.Mux.Handle
# github.com/joyent/gocommon/http
http/client_test.go:78: s.HTTPSuite.Mux.HandleFunc undefined (type *httprouter.Router has no field or method HandleFunc)
ok      github.com/joyent/gocommon      0.010s
ok      github.com/joyent/gocommon/client       0.926s
ok      github.com/joyent/gocommon/errors       0.007s
FAIL    github.com/joyent/gocommon/http [build failed]
?       github.com/joyent/gocommon/jpc  [no test files]
FAIL    github.com/joyent/gocommon/testing [build failed]

I'll fix this up.

@tgross
Copy link
Contributor Author

tgross commented Nov 14, 2016

Opened #11

@tgross tgross removed their assignment Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant