meta-pkgs/boost and devel/boost-libs

[ghost]

Initially in building boost I got the following install error for boost-libs that it couldn't find libboost-locale.a.

I noticed Jonathan's patch:

$ cvs rdiff -u -r1.15 -r1.16 pkgsrc/devel/boost-libs/PLIST
Index: pkgsrc/devel/boost-libs/PLIST
diff -u pkgsrc/devel/boost-libs/PLIST:1.15 pkgsrc/devel/boost-libs/PLIST:1.16
--- pkgsrc/devel/boost-libs/PLIST:1.15  Mon Aug 27 08:49:09 2012
+++ pkgsrc/devel/boost-libs/PLIST       Thu Sep 20 12:23:21 2012
@@ -1,4 +1,4 @@
-@comment $NetBSD: PLIST,v 1.15 2012/08/27 08:49:09 adam Exp $
+@comment $NetBSD: PLIST,v 1.16 2012/09/20 12:23:21 jperkin Exp $
 lib/libboost_chrono.a
 lib/libboost_chrono.so
 lib/libboost_chrono.so.${BOOST_VERSION}
@@ -18,9 +18,6 @@
 lib/libboost_iostreams.a
 lib/libboost_iostreams.so
 lib/libboost_iostreams.so.${BOOST_VERSION}
-lib/libboost_locale.a
-lib/libboost_locale.so
-lib/libboost_locale.so.${BOOST_VERSION}
 lib/libboost_math_c99.a
 lib/libboost_math_c99.so
 lib/libboost_math_c99.so.${BOOST_VERSION}

but I happened to notice earlier in my logs the following:

**************************************
Ignoring patch file /home/richard/src/pkgsrc/devel/boost-libs/../../meta-pkgs/boost/patches/patch-boost_functional_hash_hash.hpp: no checksum found
**************************************
===> Creating toolchain wrappers for boost-libs-1.52.0
===> Configuring for boost-libs-1.52.0
=> Fixing prefix.
=> Fixing install_name for Darwin.
cd /tmp/pkgsrc/devel/boost-libs/work/boost_1_52_0 && /usr/bin/find . -type f -print | /usr/bin/xargs /usr/bin/touch
/bin/cp -f  /opt/pkg/include/boost/config/user.hpp  /tmp/pkgsrc/devel/boost-libs/work/boost_1_52_0/boost/config/user.hpp
===> Building for boost-libs-1.52.0
ulimit -s `/usr/bin/env LC_MESSAGES=C ulimit -H -s`; ulimit -d `/usr/bin/env LC_MESSAGES=C ulimit -H -d`;                                                        cd /tmp/pkgsrc/devel/boost-libs/work/boost_1_52_0 && /usr/bin/env USETOOLS=no PTHREAD_CFLAGS=\ -D_REENTRANT PTHREAD_LDFLAGS= PTHREAD_LIBS=-lpthread\ -lrt PTHREADBASE=/usr DL_CFLAGS= DL_LDFLAGS= DL_LIBS= CC=gcc CFLAGS=-O\ -I/opt/pkg/include\ -I/usr/include CPPFLAGS=-I/opt/pkg/include\ -I/usr/include CXX=g++ CXXFLAGS=-O\ -I/opt/pkg/include\ -I/usr/include COMPILER_RPATH_FLAG=-Wl,-R F77=f77 FC=f77 FFLAGS=-O LANG=C LC_COLLATE=C LC_CTYPE=C LC_MESSAGES=C LC_MONETARY=C LC_NUMERIC=C LC_TIME=C LDFLAGS=-L/opt/pkg/gcc47/lib/gcc/x86_64-sun-solaris2.11/4.7.2\ -Wl,-R/opt/pkg/gcc47/lib/gcc/x86_64-sun-solaris2.11/4.7.2\ -L/opt/pkg/gcc47/lib\ -Wl,-R/opt/pkg/gcc47/lib\ -L/opt/pkg/lib\ -L/usr/lib\ -Wl,-R/usr/lib\ -Wl,-R/opt/pkg/lib LINKER_RPATH_FLAG=-R PATH=/tmp/pkgsrc/devel/boost-libs/work/.wrapper/bin:/tmp/pkgsrc/devel/boost-libs/work/.buildlink/bin:/tmp/pkgsrc/devel/boost-libs/work/.tools/bin:/tmp/pkgsrc/devel/boost-libs/work/.gcc/bin:/opt/pkg/bin:/opt/pkg/sbin:/opt/pkg/bin:/opt/pkg/gnu/bin:/opt/pkg/gcc47/bin:/usr/bin:/usr/sbin:/sbin:/opt/pkg/bin:/opt/pkg/bin PREFIX=/opt/pkg PKG_SYSCONFDIR=/etc/opt/pkg HOME=/tmp/pkgsrc/devel/boost-libs/work/.home CPP=cpp LINK_ALL_LIBGCC_HACK= LOCALBASE=/opt/pkg NO_WHOLE_ARCHIVE_FLAG=-z\ defaultextract WHOLE_ARCHIVE_FLAG=-z\ allextract X11BASE=/opt/pkg X11PREFIX=/opt/pkg PKGMANDIR=man PKGINFODIR=info MAKECONF=/dev/null OBJECT_FMT=ELF USETOOLS=no BSD_INSTALL_PROGRAM=/opt/pkg/bin/install-sh\ -c\ -s\ -o\ richard\ -g\ staff\ -m\ 755 BSD_INSTALL_SCRIPT=/opt/pkg/bin/install-sh\ -c\ -o\ richard\ -g\ staff\ -m\ 755 BSD_INSTALL_LIB=/opt/pkg/bin/install-sh\ -c\ -o\ richard\ -g\ staff\ -m\ 755 BSD_INSTALL_DATA=/opt/pkg/bin/install-sh\ -c\ -o\ richard\ -g\ staff\ -m\ 644 BSD_INSTALL_MAN=/opt/pkg/bin/install-sh\ -c\ -o\ richard\ -g\ staff\ -m\ 644 BSD_INSTALL=/opt/pkg/bin/install-sh BSD_INSTALL_PROGRAM_DIR=/opt/pkg/bin/install-sh\ -d\ -o\ richard\ -g\ staff\ -m\ 755 BSD_INSTALL_SCRIPT_DIR=/opt/pkg/bin/install-sh\ -d\ -o\ richard\ -g\ staff\ -m\ 755 BSD_INSTALL_LIB_DIR=/opt/pkg/bin/install-sh\ -d\ -o\ richard\ -g\ staff\ -m\ 755 BSD_INSTALL_DATA_DIR=/opt/pkg/bin/install-sh\ -d\ -o\ richard\ -g\ staff\ -m\ 755 BSD_INSTALL_MAN_DIR=/opt/pkg/bin/install-sh\ -d\ -o\ richard\ -g\ staff\ -m\ 755 BSD_INSTALL_GAME=/opt/pkg/bin/install-sh\ -c\ -s\ -o\ richard\ -g\ staff\ -m\ 2555 BSD_INSTALL_GAME_DATA=/opt/pkg/bin/install-sh\ -c\ -o\ richard\ -g\ staff\ -m\ 664 BSD_INSTALL_GAME_DIR=/opt/pkg/bin/install-sh\ -d\ -o\ richard\ -g\ staff\ -m\ 775 INSTALL_INFO= MAKEINFO=/tmp/pkgsrc/devel/boost-libs/work/.tools/bin/makeinfo FLEX= BISON= PKG_CONFIG= PKG_CONFIG_LIBDIR=/tmp/pkgsrc/devel/boost-libs/work/.buildlink/lib/pkgconfig:/tmp/pkgsrc/devel/boost-libs/work/.buildlink/share/pkgconfig PKG_CONFIG_LOG=/tmp/pkgsrc/devel/boost-libs/work/.pkg-config.log PKG_CONFIG_PATH= WRAPPER_DEBUG=no WRAPPER_UPDATE_CACHE=yes VIEWBASE=/opt/pkg /opt/pkg/bin/bjam --without-python --builddir=/tmp/pkgsrc/devel/boost-libs/work/boost_1_52_0/build --layout=system --toolset=gcc --disable-long-double release threading=multi link=shared,static cxxflags=-std=c++0x --prefix=/opt/pkg stage
Performing configuration checks

    - 32-bit                   : no
    - 64-bit                   : yes
    - x86                      : yes
    - has_icu builds           : no
warning: Graph library does not contain MPI-based parallel components.
note: to enable them, add "using mpi ;" to your user-config.jam
    - icu                      : no
    - icu (lib64)              : no
- Boost.Locale needs either iconv or ICU library to be built.
- Boost.Locale needs either iconv or ICU library to be built.
- Boost.Locale needs either iconv or ICU library to be built.
- Boost.Locale needs either iconv or ICU library to be built.
- Boost.Locale needs either iconv or ICU library to be built.
- Boost.Locale needs either iconv or ICU library to be built.
    - gcc visibility           : yes
    - long double support      : yes
warning: skipping optional Message Passing Interface (MPI) library.
note: to enable MPI support, add "using mpi ;" to user-config.jam.
note: to suppress this message, pass "--without-mpi" to bjam.
note: otherwise, you can safely ignore this message.
- Boost.Locale needs either iconv or ICU library to be built.
- Boost.Locale needs either iconv or ICU library to be built.
- Boost.Locale needs either iconv or ICU library to be built.
- Boost.Locale needs either iconv or ICU library to be built.
- Boost.Locale needs either iconv or ICU library to be built.
- Boost.Locale needs either iconv or ICU library to be built.

Component configuration:

    - chrono                   : building
    - context                  : building
    - date_time                : building
    - exception                : building
    - filesystem               : building
    - graph                    : building
    - graph_parallel           : building
    - iostreams                : building
    - locale                   : building
    - math                     : building
    - mpi                      : building
    - program_options          : building
    - python                   : not building
    - random                   : building
    - regex                    : building
    - serialization            : building
    - signals                  : building
    - system                   : building
    - test                     : building
    - thread                   : building
    - timer                    : building
    - wave                     : building

So I built and installed textproc/icu, and added icu (and expat) to PKG_DEFAULT_OPTIONS
which, indeed, allowed for a successful build and install of boost.

So I wonder if this patch is correct.

On the other hand, there is also a message (first part of log above) concerning patch-boost_functional_hash_hash.hpp...
Thought at first it was an oversight so I did a bmake mps before trying a clean build, but I got the following:

=> Applying pkgsrc patches for boost-build-1.52.0
Ignoring previously applied (or reversed) patch.
3 out of 3 hunks ignored--saving rejects to boost/functional/hash/hash.hpp.rej
Patch /home/richard/src/pkgsrc/devel/boost-build/../../meta-pkgs/boost/patches/patch-boost_functional_hash_hash.hpp failed
ERROR: Patching failed due to modified or broken patch file(s):
ERROR:  /home/richard/src/pkgsrc/devel/boost-build/../../meta-pkgs/boost/patches/patch-boost_functional_hash_hash.hpp
*** Error code 1

so I removed the file, restored distinfo and was able to build and install without incident.

It appears that this file was not deleted (yet).

[ghost]

noticed another warning

===> Building for boost-jam-1.52.0
=> Fixing path to Boost.Build files.
WARNING: [subst.mk:bb] Ignoring non-existent file "./tools/jam/src/Jambase".

so I fixed a line in devel/boost-jam/Makefile as well.

In summary, in addition to adding "icu" to options, here are the file modifications:

richard@devzone:~/src/pkgsrc/meta-pkgs/boost$ git diff --staged
diff --git a/devel/boost-jam/Makefile b/devel/boost-jam/Makefile
index a7059dc..ecf7127 100644
--- a/devel/boost-jam/Makefile
+++ b/devel/boost-jam/Makefile
@@ -11,7 +11,7 @@ CONFLICTS+=           boost-build<=1.33.1
 SUBST_CLASSES+=                bb
 SUBST_MESSAGE.bb=      Fixing path to Boost.Build files.
 SUBST_STAGE.bb=                pre-build
-SUBST_FILES.bb=                tools/jam/src/Jambase
+SUBST_FILES.bb=                tools/build/v2/engine/Jambase
 SUBST_SED.bb=          -e 's,/usr/share/boost-build,${PREFIX}/share/boost-build,g'

 .include "../../devel/boost-build/toolset.mk"
diff --git a/meta-pkgs/boost/patches/patch-boost_functional_hash_hash.hpp b/meta-pkgs/boost/patches/patch-boost_functional_hash_hash.hpp
deleted file mode 100644
index e00795f..0000000
--- a/meta-pkgs/boost/patches/patch-boost_functional_hash_hash.hpp
+++ /dev/null
@@ -1,40 +0,0 @@
-$NetBSD: patch-boost_functional_hash_hash.hpp,v 1.1 2012/08/31 12:20:56 adam Exp $
-
-Allow hashing enums.
-
---- boost/functional/hash/hash.hpp.orig        2012-07-15 23:28:30.000000000 +0000
-+++ boost/functional/hash/hash.hpp
-@@ -15,6 +15,8 @@
- #include <boost/functional/hash/detail/hash_float.hpp>
- #include <string>
- #include <boost/limits.hpp>
-+#include <boost/type_traits/is_enum.hpp>
-+#include <boost/utility/enable_if.hpp>
- 
- #if defined(BOOST_NO_TEMPLATE_PARTIAL_SPECIALIZATION)
- #include <boost/type_traits/is_pointer.hpp>
-@@ -90,6 +92,10 @@ namespace boost
-     template <typename T>
-     typename boost::hash_detail::ulong_numbers<T>::type hash_value(T);
- 
-+    template <typename T>
-+    typename boost::enable_if<boost::is_enum<T>, std::size_t>::type
-+      hash_value(T);
-+
- #if !BOOST_WORKAROUND(__DMC__, <= 0x848)
-     template <class T> std::size_t hash_value(T* const&);
- #else
-@@ -179,6 +185,13 @@ namespace boost
-         return hash_detail::hash_value_unsigned(v);
-     }
- 
-+    template <typename T>
-+    typename boost::enable_if<boost::is_enum<T>, std::size_t>::type
-+      hash_value(T v)
-+    {
-+      return static_cast<std::size_t>(v);
-+    }
-+
-     // Implementation by Alberto Barbati and Dave Harris.
- #if !BOOST_WORKAROUND(__DMC__, <= 0x848)
-     template <class T> std::size_t hash_value(T* const& v)

[mamash]

This was fixed by jperkin earlier:

TritonDataCenter/pkgsrc@9ffc01c