Python(2.7) build doesn't build the spwd module (disabled by patch-am)

[nshalman]

SaltStack has to do workarounds for user creation due to lack of the spwd module.
(See: saltstack/salt@8b0916e )

The module itself looks pretty straightforward. It's disabled by patch-am without any real explanation.

Tweaking patch-am seemed to remove it from the disable list seemed to build just fine and the resulting module appears to work.

I recommend the following patch (and associated distinfo updates):

diff --git a/lang/python27/PLIST.common b/lang/python27/PLIST.common
index 7f52c39..d6eca70 100644
--- a/lang/python27/PLIST.common
+++ b/lang/python27/PLIST.common
@@ -1854,6 +1854,7 @@ lib/python${PY_VER_SUFFIX}/lib-dynload${LIBARCHSUFFIX}/operator.so
 lib/python${PY_VER_SUFFIX}/lib-dynload${LIBARCHSUFFIX}/parser.so
 lib/python${PY_VER_SUFFIX}/lib-dynload${LIBARCHSUFFIX}/resource.so
 lib/python${PY_VER_SUFFIX}/lib-dynload${LIBARCHSUFFIX}/select.so
+lib/python${PY_VER_SUFFIX}/lib-dynload${LIBARCHSUFFIX}/spwd.so
 lib/python${PY_VER_SUFFIX}/lib-dynload${LIBARCHSUFFIX}/strop.so
 lib/python${PY_VER_SUFFIX}/lib-dynload${LIBARCHSUFFIX}/syslog.so
 lib/python${PY_VER_SUFFIX}/lib-dynload${LIBARCHSUFFIX}/termios.so
diff --git a/lang/python27/patches/patch-am b/lang/python27/patches/patch-am
index 6e82087..853bf2a 100644
--- a/lang/python27/patches/patch-am
+++ b/lang/python27/patches/patch-am
@@ -11,7 +11,6 @@ gdbm
 pyexpat
 readline
 {linux,oss,sun}audiodev
-spwd
 Those have separate packages where needed.

 Only check the BUILDLINK_DIR for libraries etc, do not pick up random
@@ -28,7 +27,7 @@ cygwin 2.7.3-no-libm.patch

  # This global variable is used to hold the list of modules to be disabled.
 -disabled_module_list = []
-+disabled_module_list = ["_bsddb", "_curses", "_curses_panel", "_elementtree", "_sqlite3", "_tkinter", "gdbm", "pyexpat", "readline", "linuxaudiodev", "ossaudiodev", "spwd", "sunaudiodev"]
++disabled_module_list = ["_bsddb", "_curses", "_curses_panel", "_elementtree", "_sqlite3", "_tkinter", "gdbm", "pyexpat", "readline", "linuxaudiodev", "ossaudiodev", "sunaudiodev"]

  def add_dir_to_list(dirlist, dir):
      """Add the directory 'dir' to the list 'dirlist' (at the front) if

[nshalman]

From an IRC conversation (notes for myself):

TritonDataCenter/pkgsrc@90d256a
suggests it can be built separately
copy from something like devel/py-readline
which uses lang/python/srcdist.mk to build bundled modules as separate packages
it'll mostly be a case of cp && s/readline/spwd/
then add it as a DEPENDS for saltstack

[nshalman]

Pull request #173 addresses this better so I'm closing this issue.